Send draft datasource ID via created_resources #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyburdi
changed the title
|
We are not moving forward with this method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a PR for sending the ID of a draft datasource config along with the job as a CreatedResource. When we test the connection successfully, we write an entry containing the draft datasource config to the
draft_configstable - this entry is referenced by the ID in the CreatedResource.In other words, we can use this ID on the front end to pull the proposed datasource name from the draft config to show in the test datasource config agent job log.
Related to https://github.com/greatexpectationslabs/mercury/pull/3186