Faststream poc #399
Open
Faststream poc #399
+527
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 12 Tests Failed:
View the top 3 failed tests by shortest run timetests.agent.test_agent�test_gx_agent_sends_request_to_create_scheduled_job tests.agent.test_agent�test_gx_agent_updates_cloud_on_job_status tests.agent.test_agent�test_gx_agent_run_handles_client_authentication_error_on_init To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Kilo59
approved these changes
Aug 20, 2024
Comment on lines
+124
to
+126
| processed_successfully=mock.Mock(), | ||
| processed_with_failures=mock.Mock(), | ||
| redeliver_message=mock.Mock(), |
There was a problem hiding this comment.
Why are the values here set to mock.Mock()?
allensallinger
approved these changes
Aug 20, 2024
rreinoldsc
reviewed
Aug 20, 2024
| @@ -1 +1 @@ | |||
| 3.10.14 | |||
| 3.11.9 | |||
There was a problem hiding this comment.
Is it best to bring this change in separately?
rreinoldsc
reviewed
Aug 20, 2024
Comment on lines
+114
to
+115
| # Use Retries = 10, --workers 1 | ||
| # Data Context as a Dependency |
There was a problem hiding this comment.
I'm not sure what these comments mean, should they stay?
Suggested change
| # Use Retries = 10, --workers 1 | |
| # Data Context as a Dependency |
rreinoldsc
reviewed
Aug 20, 2024
| @@ -10,9 +10,16 @@ | |||
| from functools import partial | |||
| from importlib.metadata import version as metadata_version | |||
| from typing import TYPE_CHECKING, Any, Callable, Dict, Final, Literal | |||
| from unittest import mock | |||
There was a problem hiding this comment.
Shouldn't have any unittest imports in production
rreinoldsc
requested changes
Aug 20, 2024
rreinoldsc
reviewed
Aug 20, 2024
| try: | ||
| organization_id = gx_agent.get_organization_id(event_context) | ||
| result = gx_agent._handle_event(event_context) | ||
| except Exception as e: |
There was a problem hiding this comment.
Can this be a more narrow catch?
rreinoldsc
reviewed
Aug 20, 2024
| if result.job_duration | ||
| else None, | ||
| "job_duration": ( | ||
| result.job_duration.total_seconds() if result.job_duration else None |
There was a problem hiding this comment.
This seems to be out of scope of your changes, but a job_duration of 0 seconds would result in None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.