Rename batch_definition_options to batch_parameters

great-expectations · Mar 22, 2024 · 2bd45ba · 2bd45ba
1 parent bccdf23
commit 2bd45ba
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/great_expectations/checkpoint/v1_checkpoint.py b/great_expectations/checkpoint/v1_checkpoint.py
@@ -163,7 +163,7 @@ def _run_validation_definitions(
         run_results: Dict[ValidationResultIdentifier, ExpectationSuiteValidationResult] = {}
         for validation_definition in self.validation_definitions:
             validation_result = validation_definition.run(
-                batch_definition_options=batch_parameters,
+                batch_parameters=batch_parameters,
                 evaluation_parameters=expectation_parameters,
                 result_format=result_format,
             )

diff --git a/great_expectations/core/validation_config.py b/great_expectations/core/validation_config.py
@@ -199,13 +199,13 @@ def _decode_data(cls, data_dict: dict) -> BatchConfig:
     def run(
         self,
         *,
-        batch_definition_options: Optional[BatchRequestOptions] = None,
+        batch_parameters: Optional[BatchRequestOptions] = None,
         evaluation_parameters: Optional[dict[str, Any]] = None,
         result_format: ResultFormat = ResultFormat.SUMMARY,
     ) -> ExpectationSuiteValidationResult:
         validator = Validator(
             batch_config=self.batch_definition,
-            batch_request_options=batch_definition_options,
+            batch_request_options=batch_parameters,
             result_format=result_format,
         )
         results = validator.validate_expectation_suite(self.suite, evaluation_parameters)

diff --git a/tests/checkpoint/test_v1_checkpoint.py b/tests/checkpoint/test_v1_checkpoint.py
@@ -463,7 +463,7 @@ def test_checkpoint_run_passes_through_runtime_params(
         )
 
         validation_definition.run.assert_called_with(
-            batch_definition_options=batch_parameters,
+            batch_parameters=batch_parameters,
             evaluation_parameters=expectation_parameters,
             result_format=ResultFormat.SUMMARY,
         )

diff --git a/tests/core/test_validation_config.py b/tests/core/test_validation_config.py
@@ -153,7 +153,7 @@ def test_passes_complex_data_to_validator(
         mock_validator.graph_validate.return_value = [ExpectationValidationResult(success=True)]
 
         validation_config.run(
-            batch_definition_options={"year": 2024},
+            batch_parameters={"year": 2024},
             evaluation_parameters={"max_value": 9000},
             result_format=ResultFormat.COMPLETE,
         )