Skip to content

Commit

Permalink
refactor: continue modifying __init__
Browse files Browse the repository at this point in the history
  • Loading branch information
@cdkini
cdkini committed Jan 24, 2022
1 parent 4e99543 commit 82f986b
Showing 1 changed file with 79 additions and 82 deletions.
161 changes: 79 additions & 82 deletions great_expectations/rule_based_profiler/profiler.py
View file
Expand Up @@ -116,90 +116,87 @@ def __init__(
"""
self._name = name
self._config_version = config_version
self._rules = rules
self._variables = variables or {}
self._data_context = data_context
self._rules = []
self._variables = variables

# rules_configs: Dict[str, Dict[str, Any]] = rules
# rule_name: str
# rule_config: Dict[str, Any]

# for rule_name, rule_config in rules_configs.items():
# domain_builder_config: dict = rule_config.get("domain_builder")

# if domain_builder_config is None:
# raise ge_exceptions.ProfilerConfigurationError(
# message=f'Invalid rule "{rule_name}": no domain_builder found.'
# )

# domain_builder: DomainBuilder = instantiate_class_from_config(
# config=domain_builder_config,
# runtime_environment={"data_context": data_context},
# config_defaults={
# "module_name": "great_expectations.rule_based_profiler.domain_builder"
# },
# )

# parameter_builders: List[ParameterBuilder] = []

# parameter_builder_configs: dict = rule_config.get("parameter_builders")

# if parameter_builder_configs:
# parameter_builder_config: dict
# for parameter_builder_config in parameter_builder_configs:
# parameter_builders.append(
# instantiate_class_from_config(
# config=parameter_builder_config,
# runtime_environment={"data_context": data_context},
# config_defaults={
# "module_name": "great_expectations.rule_based_profiler.parameter_builder"
# },
# )
# )

# expectation_configuration_builders: List[
# ExpectationConfigurationBuilder
# ] = []

# expectation_configuration_builder_configs: dict = rule_config.get(
# "expectation_configuration_builders"
# )

# if expectation_configuration_builder_configs:
# expectation_configuration_builder_config: dict
# for (
# expectation_configuration_builder_config
# ) in expectation_configuration_builder_configs:
# expectation_configuration_builders.append(
# instantiate_class_from_config(
# config=expectation_configuration_builder_config,
# runtime_environment={},
# config_defaults={
# "class_name": "DefaultExpectationConfigurationBuilder",
# "module_name": "great_expectations.rule_based_profiler.expectation_configuration_builder",
# },
# )
# )

# variables_configs: Dict[str, Dict] = self._profiler_config.get(
# "variables", {}
# )
# variables: Optional[ParameterContainer] = None

# if variables_configs:
# variables = build_parameter_container_for_variables(
# variables_configs=variables_configs
# )

# self._rules.append(
# Rule(
# name=rule_name,
# domain_builder=domain_builder,
# parameter_builders=parameter_builders,
# expectation_configuration_builders=expectation_configuration_builders,
# variables=variables,
# )
# )
rule_name: str
rule_config: Dict[str, Any]
for rule_name, rule_config in rules.items():
domain_builder_config: Optional[dict] = rule_config.get("domain_builder")

if domain_builder_config is None:
raise ge_exceptions.ProfilerConfigurationError(
message=f'Invalid rule "{rule_name}": no domain_builder found.'
)

domain_builder: DomainBuilder = instantiate_class_from_config(
config=domain_builder_config,
runtime_environment={"data_context": data_context},
config_defaults={
"module_name": "great_expectations.rule_based_profiler.domain_builder"
},
)

parameter_builders: List[ParameterBuilder] = []

parameter_builder_configs: Optional[dict] = rule_config.get(
"parameter_builders"
)

if parameter_builder_configs:
parameter_builder_config: dict
for parameter_builder_config in parameter_builder_configs:
parameter_builders.append(
instantiate_class_from_config(
config=parameter_builder_config,
runtime_environment={"data_context": data_context},
config_defaults={
"module_name": "great_expectations.rule_based_profiler.parameter_builder"
},
)
)

expectation_configuration_builders: List[
ExpectationConfigurationBuilder
] = []

expectation_configuration_builder_configs: Optional[dict] = rule_config.get(
"expectation_configuration_builders"
)

if expectation_configuration_builder_configs:
expectation_configuration_builder_config: dict
for (
expectation_configuration_builder_config
) in expectation_configuration_builder_configs:
expectation_configuration_builders.append(
instantiate_class_from_config(
config=expectation_configuration_builder_config,
runtime_environment={},
config_defaults={
"class_name": "DefaultExpectationConfigurationBuilder",
"module_name": "great_expectations.rule_based_profiler.expectation_configuration_builder",
},
)
)

if variables:
rule_variables = build_parameter_container_for_variables(
variables_configs=variables
)
else:
rule_variables = {}

self._rules.append(
Rule(
name=rule_name,
domain_builder=domain_builder,
parameter_builders=parameter_builders,
expectation_configuration_builders=expectation_configuration_builders,
variables=rule_variables,
)
)

def profile(
self,
Expand Down

0 comments on commit 82f986b

Please sign in to comment.