Merge branches 'upstream/regex' and 'upstream/regex' of github.com:gr…

…eat-expectations/great_expectations into upstream/regex
great-expectations · May 31, 2019 · c8dc221 · c8dc221
2 parents 83a5a07 + e54e5fa
commit c8dc221
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/great_expectations/dataset/sqlalchemy_dataset.py b/great_expectations/dataset/sqlalchemy_dataset.py
@@ -186,7 +186,6 @@ def __init__(self, table_name=None, engine=None, connection_string=None,
 
         if engine is not None:
             self.engine = engine
-
         else:
             try:
                 self.engine = sa.create_engine(connection_string)
@@ -204,7 +203,7 @@ def __init__(self, table_name=None, engine=None, connection_string=None,
 
 
         try:
-            insp = reflection.Inspector.from_engine(engine)
+            insp = reflection.Inspector.from_engine(self.engine)
             self.columns = insp.get_columns(table_name, schema=schema)
         except KeyError:
             # we will get a KeyError for temporary tables, since

diff --git a/tests/sqlalchemy_dataset/test_sqlalchemydataset.py b/tests/sqlalchemy_dataset/test_sqlalchemydataset.py
@@ -96,6 +96,10 @@ def test_missing_engine_error():
         assert "Engine or connection_string must be provided." in str(err)
 
 
+def test_only_connection_string():
+    SqlAlchemyDataset('test_engine', connection_string='sqlite://')
+
+
 def test_schema_custom_sql_error():
     engine = sa.create_engine('sqlite://')