Merge pull request #432 from great-expectations/feature/version_warning

Improve version mismatch warning (#401)
great-expectations · Apr 23, 2019 · e5a68e5 · e5a68e5
2 parents 8085c4d + 2a6f14e
commit e5a68e5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/great_expectations/data_asset/base.py b/great_expectations/data_asset/base.py
@@ -792,7 +792,7 @@ def validate(self, expectations_config=None, evaluation_parameters=None, catch_e
         try:
             if expectations_config['meta']['great_expectations.__version__'] != __version__:
                 warnings.warn(
-                    "WARNING: This configuration object was built using a different version of great_expectations than is currently validating it.")
+                    "WARNING: This configuration object was built using version %s of great_expectations, but is currently being valided by version %s." % (expectations_config['meta']['great_expectations.__version__'], __version__))
         except KeyError:
             warnings.warn(
                 "WARNING: No great_expectations version found in configuration object.")

diff --git a/tests/test_data_asset.py b/tests/test_data_asset.py
@@ -1214,7 +1214,7 @@ def test_meta_version_warning(self):
             out = D.validate(expectations_config={
                              "meta": {"great_expectations.__version__": "0.0.0"}, "expectations": []})
             self.assertEqual(str(w[0].message),
-                             "WARNING: This configuration object was built using a different version of great_expectations than is currently validating it.")
+                             "WARNING: This configuration object was built using version 0.0.0 of great_expectations, but is currently being valided by version %s." % ge.__version__)
 
     def test_catch_exceptions_with_bad_expectation_type(self):
         my_df = ge.dataset.PandasDataset({"x": range(10)})