[BUGFIX] check contrib requirements (#4922)

* Add check that requirements is a list, but don't crash if it's not * Make requirements for icd_ten_category expectation a list
great-expectations · Apr 21, 2022 · fa64f1a · fa64f1a
1 parent 404b979
commit fa64f1a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/assets/scripts/build_gallery.py b/assets/scripts/build_gallery.py
@@ -109,6 +109,8 @@ def get_contrib_requirements(filepath: str) -> Dict:
                 if "library_metadata" in target_ids:
                     library_metadata = ast.literal_eval(node.value)
                     requirements = library_metadata.get("requirements", [])
+                    if type(requirements) == str:
+                        requirements = [requirements]
                     requirements_info[current_class] = requirements
                     requirements_info["requirements"] += requirements
 

diff --git a/...s_experimental/expectations/expect_column_values_to_be_icd_ten_category_or_subcategory.py b/...s_experimental/expectations/expect_column_values_to_be_icd_ten_category_or_subcategory.py
@@ -166,7 +166,7 @@ def validate_configuration(
         "contributors": [
             "@andyjessen",
         ],
-        "requirements": "simple_icd_10",
+        "requirements": ["simple_icd_10"],
     }
 
 

diff --git a/great_expectations/expectations/expectation.py b/great_expectations/expectations/expectation.py
@@ -1471,6 +1471,8 @@ def _get_augmented_library_metadata(self):
                 )
             if forbidden_keys:
                 problems.append(f"Extra key(s) found: {sorted(forbidden_keys)}")
+            if type(augmented_library_metadata["requirements"]) != list:
+                problems.append("library_metadata['requirements'] is not a list ")
             if not problems:
                 augmented_library_metadata["library_metadata_passed_checks"] = True
         else: