-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI should support GCS and S3 paths for Pandas Datasources #2006
Labels
Comments
Aylr
added
blocker bug
A bug that blocks a user from completing a use case
bug
Bugs bugs bugs!
labels
Oct 21, 2020
eugmandel
added
triage
Used by the GE core team to flag issues that were not yet triaged
core-team-priority
and removed
triage
Used by the GE core team to flag issues that were not yet triaged
labels
Oct 22, 2020
eugmandel
added a commit
that referenced
this issue
Oct 27, 2020
…l help supporting S3 and GCS - see #2006
eugmandel
changed the title
Suite new CLI fails when passed a file on GCS
CLI should support GCS and S3 paths for Pandas Datasources
Oct 28, 2020
eugmandel
added
enhancement
and removed
blocker bug
A bug that blocks a user from completing a use case
bug
Bugs bugs bugs!
labels
Oct 28, 2020
eugmandel
added a commit
that referenced
this issue
Oct 28, 2020
…sts - this will help supporting S3 and GCS (#2014) * Stop using Click to check if the user provided file exists - this will help supporting S3 and GCS - see #2006 * Modified the wording of the prompt the CLI uses to ask users for the path of a data file for a Pandas datasource to emphasize that s3a:// and gs:// paths are ok too. * Updated the changelog
CLI will accept filesystem, "s3a://" and "gs://" paths as valid inputs when prompting for a data file for a Pandas Datasource. Implemented. |
alexsherstinsky
pushed a commit
to alexsherstinsky/great_expectations
that referenced
this issue
Feb 19, 2021
…sts - this will help supporting S3 and GCS (great-expectations#2014) * Stop using Click to check if the user provided file exists - this will help supporting S3 and GCS - see great-expectations#2006 * Modified the wording of the prompt the CLI uses to ask users for the path of a data file for a Pandas datasource to emphasize that s3a:// and gs:// paths are ok too. * Updated the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Suite new CLI fails when passed a file on GCS
To Reproduce
Steps to reproduce the behavior:
0.
pip install gcsfs
(this allows pandas to usegs://
urls natively inread_csv
)great_expectations suite new
Expected behavior
I expect the file to be found and proceed with the suite creation without arduous workarounds that require contributor level experience.
Environment (please complete the following information):
Additional context
Note when you have a working notebook (which requires selecting a local file then modifying the batch kwargs) you can prove that it should work:
The text was updated successfully, but these errors were encountered: