Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing #207

Closed
jpcampb2 opened this issue Mar 1, 2018 · 4 comments
Closed

Improve typing #207

jpcampb2 opened this issue Mar 1, 2018 · 4 comments

Comments

@jpcampb2
Copy link

jpcampb2 commented Mar 1, 2018

This is a long-term issue that will collect issues surrounding the use of types in great expectations.

Opening now to flag the coercion of boolean True/False by column_aggregate_expectations in ways that may be counterintuitive.

In general, we've talked about wanting to handle gracefully all of the following realities, while emphasizing semantic types:

  • "semantic" types, such as continuous, categorical, boolean
  • "data" types: such as number, string, boolean
  • "implementation" types: int64, int32, utf-8, etc
@abegong
Copy link
Member

abegong commented Mar 1, 2018

Linking #110

@abegong
Copy link
Member

abegong commented Mar 13, 2018

Here's how SQLAlchemy handles typing: http://docs.sqlalchemy.org/en/latest/core/type_basics.html.

Might be a good starting point...

@stale
Copy link

stale bot commented Mar 11, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 11, 2020
@jcampbell
Copy link
Member

Improvements to "implementation" types are in place, and other type issues are currently handled by bundling expectations or custom expectations in practice.

@jcampbell jcampbell removed the wontfix label Mar 11, 2020
alexsherstinsky added a commit to alexsherstinsky/great_expectations that referenced this issue Nov 3, 2020
…erstinsky/refactor/merge_caches_in_data_connector_in_memory_dataset_fixing_tests-10_31_2020_36

Alexsherstinsky/refactor/merge caches in data connector in memory dataset fixing tests 10 31 2020 36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants