Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource new overwrites existing datasources with the same name #2085

Closed
spbail opened this issue Nov 25, 2020 · 6 comments
Closed

datasource new overwrites existing datasources with the same name #2085

spbail opened this issue Nov 25, 2020 · 6 comments
Labels
bug Bugs bugs bugs! feature:cli good first issue Good issues for new contributors. Join #contributors-contributing in our Slack for help! help wanted Issues we'd love to see community contributions for. Join #contributors-contributing in our Slack! stale Stale issues and PRs

Comments

@spbail
Copy link
Contributor

spbail commented Nov 25, 2020

Describe the bug
Creating a new datasource with the CLI overwrites existing datasources with the same name without warning.

To Reproduce
Steps to reproduce the behavior:

  1. Run great_expectations datasource new and create a new filesystem datasource e.g. "data__dir", pointing to a directory "dir1"
  2. Do the same thing again, give it the same name but point it at "dir2", and check great_expectations.yml - only the second datasource is in the yml.

Expected behavior
I would expect a warning or a confirmation that I'm overwriting an existing datasource.

Environment (please complete the following information):

  • OS: mac OS 11 (Big Sur)
  • GE Version: GE 0.13 (but I assume this exist in previous versions too)
@spbail spbail added bug Bugs bugs bugs! feature:cli labels Nov 25, 2020
@eugmandel eugmandel added triage Used by the GE core team to flag issues that were not yet triaged good first issue Good issues for new contributors. Join #contributors-contributing in our Slack for help! help wanted Issues we'd love to see community contributions for. Join #contributors-contributing in our Slack! and removed triage Used by the GE core team to flag issues that were not yet triaged labels Nov 30, 2020
@thcidale0808
Copy link
Contributor

@eugmandel can I implement this issue?

@eugmandel
Copy link
Contributor

@thcidale0808 Of course! This is why we added the "help wanted" label. Please submit a PR and we will help you get it in.

@thcidale0808
Copy link
Contributor

will do! Thanks!

@alfredo-f
Copy link

It seems like function check_if_datasource_name_exists has been implemented to solve this issue.

Is this correct @anthonyburdi ?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?\n\nThis issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale issues and PRs label Jul 4, 2021
@anthonyburdi
Copy link
Member

That is correct, thanks for the heads up @alfredo-f !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs bugs bugs! feature:cli good first issue Good issues for new contributors. Join #contributors-contributing in our Slack for help! help wanted Issues we'd love to see community contributions for. Join #contributors-contributing in our Slack! stale Stale issues and PRs
Projects
None yet
Development

No branches or pull requests

5 participants