Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't pass both a connection string and config options to connect method in sqlalchemycontext #369

Closed
elsander opened this issue Sep 19, 2018 · 0 comments

Comments

@elsander
Copy link
Contributor

In theory, the options argument in the connect method is meant to allow you to pass arguments to the connection method for either the pandas or sql context. However, for the sqlalchemy context, the first argument to create_engine is an unnamed argument containing the database URL. I can't find a way to pass both a db connection string and a dict of config options, which means that I can't use the class connect to databases where I require non-default options. My current workaround is to create my own engine and pass it in to SqlAlchemyDataset.

The current data context test demonstrates this behavior by passing a connection string rather than config options to the connect method:

context = get_data_context('SqlAlchemy', test_db_connection_string)

jpcampb2 pushed a commit that referenced this issue Oct 11, 2018
Allow users to pass engine connection options to SqlAlchemyDataContext (#369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant