Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/snowflake transient #1123

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Feature/snowflake transient #1123

merged 2 commits into from
Mar 5, 2020

Conversation

jcampbell
Copy link
Member

No description provided.

Signed-off-by: James Campbell <james.p.campbell@gmail.com>
@jcampbell jcampbell force-pushed the feature/snowflake_transient branch from afcef94 to d1ab4a2 Compare March 5, 2020 22:44
@jcampbell jcampbell requested a review from Aylr March 5, 2020 22:44
@coveralls
Copy link

coveralls commented Mar 5, 2020

Coverage Status

Coverage increased (+0.007%) to 77.457% when pulling 4e8d5bc on feature/snowflake_transient into 96328c2 on develop.

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #1123 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1123      +/-   ##
===========================================
+ Coverage    77.45%   77.58%   +0.13%     
===========================================
  Files          103      103              
  Lines        11743    11809      +66     
===========================================
+ Hits          9095     9162      +67     
+ Misses        2648     2647       -1     
Impacted Files Coverage Δ
great_expectations/dataset/pandas_dataset.py 88.78% <0.00%> (+0.27%) ⬆️
...t_expectations/datasource/sqlalchemy_datasource.py 90.65% <0.00%> (+1.13%) ⬆️
...ns/profile/sample_expectations_dataset_profiler.py 95.81% <0.00%> (+2.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96328c2...4e8d5bc. Read the comment docs.

Copy link
Contributor

@Aylr Aylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❄️ 🎉 LGTM

@Aylr Aylr merged commit 68c2e10 into develop Mar 5, 2020
@Aylr Aylr deleted the feature/snowflake_transient branch March 5, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants