Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError when validating expectations from a JSON file #1238

Merged

Conversation

eorbe
Copy link
Contributor

@eorbe eorbe commented Mar 28, 2020

When validating expectations from a JSON file (ge_df.validate(expectation_suite='a-ge-suite.json')) the following error is raised:

AttributeError: 'ExpectationSuite' object has no attribute 'data'

This issue is raised when trying to access the data attribute in the ExpectationSuite object created from the JSON file.

This PR removes the invalid attribute access.

@gx-cla-bot
Copy link

gx-cla-bot bot commented Mar 28, 2020

Unfortunately, I wasn't able to check some commits, because I couldn't find github login information for the author OR committer. :(Commits missing login: ad0f7de

@coveralls
Copy link

coveralls commented Mar 28, 2020

Coverage Status

Coverage remained the same at 77.708% when pulling e0cab78 on eorbe:fix_dataasset_validate_method into 0ca5c3e on great-expectations:develop.

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1238 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1238   +/-   ##
========================================
  Coverage    77.70%   77.70%           
========================================
  Files          106      106           
  Lines        12022    12022           
========================================
  Hits          9342     9342           
  Misses        2680     2680           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca5c3e...e0cab78. Read the comment docs.

@gx-cla-bot
Copy link

gx-cla-bot bot commented Mar 28, 2020

Unfortunately, I wasn't able to check some commits, because I couldn't find github login information for the author OR committer. :(Commits missing login: ad0f7de

@eorbe eorbe force-pushed the fix_dataasset_validate_method branch from 03f8653 to e0cab78 Compare March 28, 2020 18:39
@gx-cla-bot
Copy link

gx-cla-bot bot commented Mar 28, 2020

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: eorbe

@eorbe
Copy link
Contributor Author

eorbe commented Mar 28, 2020

@cla-bot check

@gx-cla-bot
Copy link

gx-cla-bot bot commented Mar 28, 2020

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: eorbe

@eorbe
Copy link
Contributor Author

eorbe commented Mar 28, 2020

@cla-bot check

@gx-cla-bot
Copy link

gx-cla-bot bot commented Mar 28, 2020

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: eorbe

@kyleaton
Copy link
Member

@cla-bot check

@jcampbell jcampbell merged commit 65f441d into great-expectations:develop Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants