New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttributeError when validating expectations from a JSON file #1238
Fix AttributeError when validating expectations from a JSON file #1238
Conversation
Unfortunately, I wasn't able to check some commits, because I couldn't find github login information for the author OR committer. :(Commits missing login: ad0f7de |
Codecov Report
@@ Coverage Diff @@
## develop #1238 +/- ##
========================================
Coverage 77.70% 77.70%
========================================
Files 106 106
Lines 12022 12022
========================================
Hits 9342 9342
Misses 2680 2680 Continue to review full report at Codecov.
|
Unfortunately, I wasn't able to check some commits, because I couldn't find github login information for the author OR committer. :(Commits missing login: ad0f7de |
03f8653
to
e0cab78
Compare
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: eorbe |
@cla-bot check |
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: eorbe |
@cla-bot check |
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: eorbe |
@cla-bot check |
When validating expectations from a JSON file (
ge_df.validate(expectation_suite='a-ge-suite.json')
) the following error is raised:This issue is raised when trying to access the
data
attribute in theExpectationSuite
object created from the JSON file.This PR removes the invalid attribute access.