New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow UpdateDataDocsAction to also specify data doc sites to build #1256
Allow UpdateDataDocsAction to also specify data doc sites to build #1256
Conversation
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: troxil |
@cla-bot check |
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: troxil |
Codecov Report
@@ Coverage Diff @@
## develop #1256 +/- ##
========================================
Coverage 77.76% 77.76%
========================================
Files 107 107
Lines 12334 12335 +1
========================================
+ Hits 9591 9592 +1
Misses 2743 2743
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Could you please add a note to the changelog and docstring for the action?
Also -- let me know about any questions/issues with the CLA!
@cla-bot check |
Thank you for submitting to Great Expectations! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 This linter comment has been updated based on the most recent commit. Comment last updated at 2020-04-07 12:28:49 UTC |
Thank you! |
Rationale
DataContext
->build_data_docs
can support a list of certain sites you want docs written to. This PR enables the same from within theUpdateDataDocsAction
.Changes
target_site_names
which would be a list (I didn't see any typing used so I didn't add in a type checkList[str]
.Sample
great_expectations.yml
: