Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UpdateDataDocsAction to also specify data doc sites to build #1256

Merged

Conversation

troxil
Copy link
Contributor

@troxil troxil commented Apr 5, 2020

Rationale

  • DataContext -> build_data_docs can support a list of certain sites you want docs written to. This PR enables the same from within the UpdateDataDocsAction.

Changes

  • By supplying a new config target_site_names which would be a list (I didn't see any typing used so I didn't add in a type check List[str].

Sample great_expectations.yml:

validation_operators:
  action_list_operator:
    class_name: ActionListValidationOperator
    action_list:
    - name: update_fun_data_docs
      action:
        class_name: UpdateDataDocsAction
        target_site_names:
          - fun_site

@gx-cla-bot
Copy link

gx-cla-bot bot commented Apr 5, 2020

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: troxil

@troxil
Copy link
Contributor Author

troxil commented Apr 5, 2020

@cla-bot check

@gx-cla-bot
Copy link

gx-cla-bot bot commented Apr 5, 2020

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GE in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to @kyleaton, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: troxil

@coveralls
Copy link

coveralls commented Apr 5, 2020

Coverage Status

Coverage increased (+0.002%) to 77.762% when pulling 1cc9cd7 on troxil:data_docs_write_select_sites into 996e33f on great-expectations:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 77.72% when pulling 5ae9cb7 on troxil:data_docs_write_select_sites into e37a033 on great-expectations:develop.

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #1256 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1256   +/-   ##
========================================
  Coverage    77.76%   77.76%           
========================================
  Files          107      107           
  Lines        12334    12335    +1     
========================================
+ Hits          9591     9592    +1     
  Misses        2743     2743           
Impacted Files Coverage Δ
great_expectations/validation_operators/actions.py 81.05% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996e33f...1cc9cd7. Read the comment docs.

Copy link
Member

@jcampbell jcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Could you please add a note to the changelog and docstring for the action?

Also -- let me know about any questions/issues with the CLA!

@troxil
Copy link
Contributor Author

troxil commented Apr 7, 2020

@cla-bot check

@pep8speaks
Copy link

pep8speaks commented Apr 7, 2020

Thank you for submitting to Great Expectations!

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 This linter comment has been updated based on the most recent commit.

Comment last updated at 2020-04-07 12:28:49 UTC

@jcampbell
Copy link
Member

Thank you!

@jcampbell jcampbell merged commit a956471 into great-expectations:develop Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants