Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profile CLI command parameter docstring #1272

Merged
merged 5 commits into from Apr 8, 2020
Merged

Remove profile CLI command parameter docstring #1272

merged 5 commits into from Apr 8, 2020

Conversation

mzjp2
Copy link
Contributor

@mzjp2 mzjp2 commented Apr 7, 2020

Resolves #1271 -- looks like this now (see issue for what it used to look like):

image

I apologise for the small PR, but it was bugging me 馃憖

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage increased (+0.02%) to 77.759% when pulling 80f77ac on mzjp2:fix/profile-docstring into 9323f9f on great-expectations:develop.

@Aylr
Copy link
Contributor

Aylr commented Apr 7, 2020

@ge-cla-bot check

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1272 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1272   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files          107      107           
  Lines        12360    12360           
========================================
  Hits          9611     9611           
  Misses        2749     2749           
Impacted Files Coverage 螖
great_expectations/cli/datasource.py 70.76% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9323f9f...80f77ac. Read the comment docs.

@mzjp2
Copy link
Contributor Author

mzjp2 commented Apr 7, 2020

Snuck in a little fix for the 0.9.8 changelog -- hope you don't mind 馃憖

Copy link
Contributor

@Aylr Aylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@Aylr Aylr merged commit fa2851a into great-expectations:develop Apr 8, 2020
@mzjp2 mzjp2 deleted the fix/profile-docstring branch April 8, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

profile CLI help text mistakenly includes Python parameter docstrings
3 participants