Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI command experimental decorator #1328

Merged
merged 2 commits into from Apr 22, 2020
Merged

CLI command experimental decorator #1328

merged 2 commits into from Apr 22, 2020

Conversation

Aylr
Copy link
Contributor

@Aylr Aylr commented Apr 22, 2020

What's Here

A tiny decorator that can be applied to CLI functions to increase consistency of feature readiness messaging.


@Aylr Aylr changed the title CLI command beta decorator WIP CLI command beta decorator Apr 22, 2020
@Aylr Aylr changed the title WIP CLI command beta decorator CLI command beta decorator Apr 22, 2020
@jcampbell
Copy link
Member

Design: 👍

@codecov
Copy link

codecov bot commented Apr 22, 2020 •
edited

Codecov Report

Merging #1328 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1328   +/-   ##
========================================
  Coverage    78.36%   78.37%           
========================================
  Files          122      122           
  Lines        13405    13411    +6     
========================================
+ Hits         10505    10511    +6     
  Misses        2900     2900
Impacted Files Coverage Δ
great_expectations/cli/datasource.py 70.87% <100.00%> (ø)
great_expectations/cli/tap.py 91.66% <100.00%> (ø)
great_expectations/cli/util.py 89.77% <100.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db16900...efe6672. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 22, 2020 •
edited

Coverage Status

Coverage increased (+0.002%) to 78.369% when pulling efe6672 on aylr/mark-cli-beta into db16900 on develop.

ayirplm
ayirplm approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@ayirplm ayirplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace checkpoints with taps - ok we'll catch it in our enmasse replace, otherwise, LGTM

@Aylr Aylr changed the title CLI command beta decorator CLI command experimental decorator Apr 22, 2020
@Aylr Aylr merged commit 789d862 into develop Apr 22, 2020
@Aylr Aylr deleted the aylr/mark-cli-beta branch April 22, 2020 21:16
alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this pull request Feb 19, 2021
@Aylr
CLI command experimental decorator (great-expectations#1328)
6595548 
* * small simple decorator for CLI methods to have consistent BETA messaging.
* Made all docstrings consistent

* * change beta to experimental to align with feature maturity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayirplm ayirplm ayirplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aylr @jcampbell @coveralls @ayirplm