Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update index.rst #1482

Merged
merged 12 commits into from
May 28, 2020
Merged

[DOCS] Update index.rst #1482

merged 12 commits into from
May 28, 2020

Conversation

abegong
Copy link
Member

@abegong abegong commented May 23, 2020

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [ENHANCEMENT], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Fills in gaps in Getting Started
  • Makes bash commands, code blocks, JSON objects, screen shots, etc. consistent through the tutorial
  • Applies styling to intro.rst

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Thank you for submitting!

@coveralls
Copy link

coveralls commented May 23, 2020

Coverage Status

Coverage decreased (-72.4%) to 0.0% when pulling 2097a91 on docs/20200523-A into 2cb5b17 on develop.

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #1482 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1482   +/-   ##
========================================
  Coverage    76.90%   76.90%           
========================================
  Files          130      130           
  Lines        14787    14787           
========================================
  Hits         11372    11372           
  Misses        3415     3415           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb5b17...2097a91. Read the comment docs.

@abegong
Copy link
Member Author

abegong commented May 23, 2020

This is ready to go!

@abegong
Copy link
Member Author

abegong commented May 26, 2020

@jcampbell Any concerns about these changes? I'd love to get them merged before all the good people come back from the weekend.

Copy link
Contributor

@Aylr Aylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FF to merge this after 1 small change is made.

|-- great_expectations.yml
|-- checkpoints
|-- expectations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkpoints directory is missing.

@abegong
Copy link
Member Author

abegong commented May 28, 2020

Good catch, @Aylr .

@abegong abegong merged commit e9f71b2 into develop May 28, 2020
@abegong abegong deleted the docs/20200523-A branch May 28, 2020 04:00
alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this pull request Feb 19, 2021
* Update index.rst

* Update index.rst

* Styling and links on intro.rst

* Fix ipsum in getting_started

* Tidy up Download example data

* Simplify initialize_a_data_context; Update connect_to_data

* update create_your_first_expectations.rst

* Update more code blocks

* Minimial revisions to pick_your_deployment_pattern

* Plug in screen shots

* Update initialize_a_data_context.rst

Add `        |-- checkpoints`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants