Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Create stubbed files for the creating_and_editing_expectations section of the how-to guides. #1493

Merged

Conversation

abegong
Copy link
Member

@abegong abegong commented May 27, 2020

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [ENHANCEMENT], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • This PR creates stubbed files for the creating_and_editing_expectations section of the how-to guides.

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Thank you for submitting!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.415% when pulling f51934e on docs/rationalize_how_to_create_and_edit_expectations into ef289ea on develop.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #1493 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1493      +/-   ##
===========================================
- Coverage    76.91%   76.90%   -0.02%     
===========================================
  Files          130      130              
  Lines        14787    14787              
===========================================
- Hits         11374    11372       -2     
- Misses        3413     3415       +2     
Impacted Files Coverage Δ
...ctations/core/usage_statistics/usage_statistics.py 81.06% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef289ea...f51934e. Read the comment docs.

Copy link
Contributor

@eugmandel eugmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abegong Let's add the Prerequisites info box from #1491

@abegong
Copy link
Member Author

abegong commented May 27, 2020

I don't think it makes sense to gate on that change.

  1. [DOCS] Added a Prerequisites info box to the how-to guide template #1491 hasn't even been merged yet.
  2. These are stubs. They don't have prerequisites. Once we actually writing the articles, they should include Prerequisites. But not the stubs.

@eugmandel
Copy link
Contributor

I don't think it makes sense to gate on that change.

  1. [DOCS] Added a Prerequisites info box to the how-to guide template #1491 hasn't even been merged yet.
  2. These are stubs. They don't have prerequisites. Once we actually writing the articles, they should include Prerequisites. But not the stubs.

OK. Let's not gate on this change.

@abegong abegong merged commit 39fcbf0 into develop May 27, 2020
Shinnnyshinshin pushed a commit that referenced this pull request May 27, 2020
draft 2 before formatting

Update with Slack Screenshot

minor change to pre-requisites

Stub files and move others to spare_parts/ (#1493)

Capitalize Slack

undo change to .gitignore
@jcampbell jcampbell deleted the docs/rationalize_how_to_create_and_edit_expectations branch July 31, 2020 14:44
alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants