Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting_started.rst #1499

Merged
merged 1 commit into from
May 28, 2020
Merged

Update getting_started.rst #1499

merged 1 commit into from
May 28, 2020

Conversation

abegong
Copy link
Member

@abegong abegong commented May 28, 2020

I think we're ready to drop this warning message.

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [ENHANCEMENT], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Drop "warning" that points people away from the Getting started tutorial

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Thank you for submitting!

I think we're ready to drop this warning message.
Copy link
Contributor

@Aylr Aylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@Aylr Aylr merged commit 1066cc2 into develop May 28, 2020
@Aylr Aylr deleted the docs/drop-warning branch May 28, 2020 15:51
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.415% when pulling 3f41ac9 on docs/drop-warning into e25f5da on develop.

Shinnnyshinshin pushed a commit that referenced this pull request May 29, 2020
I think we're ready to drop this warning message.
alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this pull request Feb 19, 2021
I think we're ready to drop this warning message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants