[BUGFIX] bugfix missing checkpoints directory from init message #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abegong
approved these changes
May 28, 2020
There was a problem hiding this comment.
I swapped the display order with expectations/ so that (1) it's consistent with the output shown here (https://docs.greatexpectations.io/en/latest/tutorials/getting_started/initialize_a_data_context.html#run-great-expectations-init) and (2) Expectations gets top billing.
Codecov Report
@@ Coverage Diff @@
## develop #1500 +/- ##
========================================
Coverage 76.90% 76.90%
========================================
Files 130 130
Lines 14787 14787
========================================
Hits 11372 11372
Misses 3415 3415
Continue to review full report at Codecov.
|
Shinnnyshinshin
pushed a commit
that referenced
this pull request
May 29, 2020
* * bugfix missing checkpoints directory from init message * Update cli_messages.py Co-authored-by: Abe Gong <abegong@users.noreply.github.com>
alexsherstinsky
pushed a commit
to alexsherstinsky/great_expectations
that referenced
this pull request
Feb 19, 2021
…t-expectations#1500) * * bugfix missing checkpoints directory from init message * Update cli_messages.py Co-authored-by: Abe Gong <abegong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Thank you for submitting!