[BUGFIX] Escape $ characters in configuration, support multiple substitutions #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons in a single string and support for uppercase patterns
…rd-substitution' into anthony/bugfix/issue-2005-password-substitution # Conflicts: # docs/changelog.rst
eugmandel
suggested changes
Oct 29, 2020
There was a problem hiding this comment.
@anthonyburdi I think the CLI escaping logic is missing: https://www.loom.com/share/dc72d194153a4354939696403a1db5b8
eugmandel
approved these changes
Oct 29, 2020
anthonyburdi
deleted the
anthony/bugfix/issue-2005-password-substitution
branch
alexsherstinsky
pushed a commit
to alexsherstinsky/great_expectations
that referenced
this pull request
Feb 19, 2021
…itutions (great-expectations#2015) * Escape substitution of variables, add handling of multiple substitutions in a single string and support for uppercase patterns * Handle loading of escaped values, add tests and some documentation * Change escape string, define escape string in BaseDataContext * Add documentation * changelog * Also handle escaping dicts, OrderedDicts and lists when saving config_variables * Add test for escaping dict when writing to config_variables.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts PR #1949 and instead adds escaping for the
$character via\to configuration substitution. For example, you can now setpassword: pa\$swordif your password ispa$sword. Additionally, it adds support for multiple substitutions in the same item, e.g.database_string: ${USER}:${PASSWORD}@${HOST}:${PORT}/${DATABASE}. It also adds escaping when saving items, e.g. via the CLI.Closes #2005