[ENHANCEMENT] Pre-hackathon improvement in the contrib dev loop process and documentation #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r better readability
…r better readability
…r better readability
…ithub.com:great-expectations/great_expectations into eugene/expectations_contrib_improvements_20210121
…r better readability
…ithub.com:great-expectations/great_expectations into eugene/expectations_contrib_improvements_20210121
…encountered in the process of running the diagnostics, they are assumed to be due to
incompleteness of the Expectation's implementation (e.g., declaring a dependency on Metrics
that do not exist). These errors are added under "errors" key in the report.
…ery = True are included in the report's "example" section, all tests are executed for the "test_report" section.
…ithub.com:great-expectations/great_expectations into eugene/expectations_contrib_improvements_20210121
…on templates and document this attribute in the how-to guide
eugmandel
changed the title
…ors that submit Expectations to contrib
…ithub.com:great-expectations/great_expectations into eugene/expectations_contrib_improvements_20210121
…k from James, adjusted the structure of the report output in the snippet
…tion.run_diagnostics.
alexsherstinsky
approved these changes
Jan 22, 2021
eugmandel
deleted the
eugene/expectations_contrib_improvements_20210121
branch
robertparker
pushed a commit
to robertparker/great_expectations
that referenced
this pull request
Feb 4, 2021
…ss and documentation (great-expectations#2296) Expectation.run_diagnostics: * "Hardening" of the logic: Original implementation did not catch any Exceptions and could not produce a report when it did. The change: if errors are encountered in the process of running the diagnostics, they are assumed to be due to incompleteness of the Expectation's implementation (e.g., declaring a dependency on Metrics that do not exist). These errors are added under "diagnostics_report" key in the report. while only examples with include_in_gallery = True are included in the report's "example" section, all tests are executed for the "test_report" section. * "How to contribute a new Expectation to Great Expectations: how-to guide: Multiple readability improvements based on the feedback from Alex, Anthony and Gil. * Include include_in_gallery attribute in the examples in the Expectation templates and document this attribute in the how-to guide
alexsherstinsky
pushed a commit
to alexsherstinsky/great_expectations
that referenced
this pull request
Feb 19, 2021
…ss and documentation (great-expectations#2296) Expectation.run_diagnostics: * "Hardening" of the logic: Original implementation did not catch any Exceptions and could not produce a report when it did. The change: if errors are encountered in the process of running the diagnostics, they are assumed to be due to incompleteness of the Expectation's implementation (e.g., declaring a dependency on Metrics that do not exist). These errors are added under "diagnostics_report" key in the report. while only examples with include_in_gallery = True are included in the report's "example" section, all tests are executed for the "test_report" section. * "How to contribute a new Expectation to Great Expectations: how-to guide: Multiple readability improvements based on the feedback from Alex, Anthony and Gil. * Include include_in_gallery attribute in the examples in the Expectation templates and document this attribute in the how-to guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
include_in_galleryattribute in the examples in the Expectation templates and document this attribute in the how-to guidePrevious Design Review notes: