Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Documentation addition to clarify conda requirements_dev.txt installation #2306

Merged
merged 3 commits into from Jan 22, 2021

Conversation

gilpasternak35
Copy link
Contributor

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [ENHANCEMENT], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Clarify conda requirements_dev.txt installation

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Thank you for submitting!

Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	docs/contributing/setting_up_your_dev_environment.rst
@anthonyburdi
Copy link
Member

@gilpasternak35 FYI I fixed the merge conflict and also changed Macbook to MacOS to be a bit more general.

@eugmandel eugmandel merged commit e815316 into develop Jan 22, 2021
@eugmandel eugmandel deleted the docs/contrib_updates branch January 22, 2021 22:01
robertparker pushed a commit to robertparker/great_expectations that referenced this pull request Feb 4, 2021
…nstallation (great-expectations#2306)

* Doc updates

* Small addition

Co-authored-by: Anthony Burdi <anthony@superconductive.com>
alexsherstinsky pushed a commit to alexsherstinsky/great_expectations that referenced this pull request Feb 19, 2021
…nstallation (great-expectations#2306)

* Doc updates

* Small addition

Co-authored-by: Anthony Burdi <anthony@superconductive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants