[MAINTENANCE] Add checkpoint store to store backend defaults #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aults_with_variable_sub
…to-store-backend-defaults
|
@alexsherstinsky I've asked @Shinnnyshinshin to review on this change, and tagging you as a reviewer as an FYI since you recently edited this code. But please if you feel like reviewing as well by all means - go for it! |
|
Thank you sir :) looks wonderful. Also, I appreciate that you spelled this connection out: |
Shinnnyshinshin
approved these changes
Feb 3, 2021
…to-store-backend-defaults
…to-store-backend-defaults
…to-store-backend-defaults
…to-store-backend-defaults
anthonyburdi
deleted the
anthony/maintenance/add-checkpoint-store-to-store-backend-defaults
branch
alexsherstinsky
pushed a commit
to alexsherstinsky/great_expectations
that referenced
this pull request
Feb 19, 2021
…xpectations#2378) * add checkpoint store root_directory to FilesystemStoreBackendDefaults * add checkpoint store to S3StoreBackendDefaults * add checkpoint store to GCSStoreBackendDefaults * add checkpoint store to DatabaseStoreBackendDefaults * add checkpoint_store_name default to DataContextConfig * fix default checkpoint store names * fix default checkpoint store prefixes * fix test_DataContextConfig_with_S3StoreBackendDefaults * fix test_DataContextConfig_with_S3StoreBackendDefaults_using_all_parameters * fix test_DataContextConfig_with_FilesystemStoreBackendDefaults_and_simple_defaults * fix test_DataContextConfig_with_GCSStoreBackendDefaults * fix test_DataContextConfig_with_GCSStoreBackendDefaults_using_all_parameters * fix test_DataContextConfig_with_DatabaseStoreBackendDefaults * fix test_DataContextConfig_with_DatabaseStoreBackendDefaults_using_all_parameters * fix test_DataContextConfig_with_S3StoreBackendDefaults_and_simple_defaults_with_variable_sub * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: