[DOCS] Fix documentation links generated within template #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cla-bot check |
|
@thejasraju Thank you for spotting the broken docs links! |
eugmandel
approved these changes
Mar 13, 2021
|
@thejasraju Approved the PR! Could you please make sure to sign the CLA (Contributor License Agreement), so that I can merge? Thank you! |
|
Thanks for the review @eugmandel , I signed the Superconductive: Individual Contributor License Agreement v1.0 earlier and commented, didn't seem to have worked so I submitted a new response in the form. |
|
I think it should work now, apologies for the back and forth: @cla-bot check |
peterdhansen
pushed a commit
to peterdhansen/great_expectations
that referenced
this pull request
Mar 29, 2021
…#2542) Co-authored-by: traju <traju@shutterstock.com> Co-authored-by: Eugene Mandel <eugene.mandel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The documentation links for data context points to invalid URL.
Invalid URL: https://docs.greatexpectations.io/en/latest/how_to_guides/spare_parts/data_context_reference.html#configuration
Valid URL: https://docs.greatexpectations.io/en/latest/reference/spare_parts/data_context_reference.html#configuration
The documentation links for adding new data source also points to invalid URL.
Invalid URL: https://docs.greatexpectations.io/en/latest/reference/core_concepts/datasource_reference.html
Valid URL: https://docs.greatexpectations.io/en/latest/reference/core_concepts/datasource.html
The proposed changes fix these invalid links.