Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] CLI docs build command implemented for v3 api #2614

Merged
merged 1 commit into from Mar 26, 2021

Conversation

Aylr
Copy link
Contributor

@Aylr Aylr commented Mar 26, 2021

    • [ENHANCEMENT] CLI docs build command implemented for v3 api

@Aylr Aylr changed the title * [ENHANCEMENT] CLI docs build command implemented for v3 api [ENHANCEMENT] CLI docs build command implemented for v3 api Mar 26, 2021
@Aylr Aylr enabled auto-merge (squash) March 26, 2021 21:25
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀LGTM!🚀🚀

input="\n",
catch_exceptions=False,
)
stdout = result.stdout
print(result.output)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😉

assert (
"great_expectations/uncommitted/data_docs/local_site/index.html"
in obs_urls[0]["site_url"]
)
local_site_dir = os.path.join(root_dir, "uncommitted/data_docs/local_site/")
site_dir = os.path.join(
root_dir, context.GE_UNCOMMITTED_DIR, "data_docs", "local_site"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My man! ✋

@Aylr Aylr merged commit 7b6393c into develop Mar 26, 2021
@Aylr Aylr deleted the cli-docs-build-v3 branch March 26, 2021 21:54
peterdhansen pushed a commit to peterdhansen/great_expectations that referenced this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants