Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] DataContext.clean_data_docs now raises helpful errors #2621

Merged
merged 1 commit into from Mar 30, 2021

Conversation

Aylr
Copy link
Contributor

@Aylr Aylr commented Mar 29, 2021

[ENHANCEMENT] DataContext.clean_data_docs now raises helpful errors

@Aylr Aylr requested a review from anthonyburdi March 29, 2021 19:56
@Aylr Aylr force-pushed the clean-docs-tests-and-error-messages branch from 4426e3c to b245827 Compare March 29, 2021 20:03
@Aylr Aylr changed the title [BUGFIX] DataContext.clean_data_docs now raises helpful errors and cleans expected sites and no longer throws AttributeError when no sites are configured [ENHANCEMENT] DataContext.clean_data_docs now raises helpful errors Mar 29, 2021
@Aylr Aylr enabled auto-merge (squash) March 29, 2021 20:03
@Aylr Aylr force-pushed the clean-docs-tests-and-error-messages branch from b245827 to 24c1ba5 Compare March 29, 2021 20:04
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it - thanks for diving into this!

This removes all files from the configured Store.

Args:
site_name (str): Optional, the name of the site to clean. If not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

assert not os.path.isfile(
os.path.join(data_docs_dir, "another_local_site", "index.html")
)
assert os.path.isfile(os.path.join(data_docs_dir, "local_site", "index.html"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Aylr Aylr merged commit 70975fe into develop Mar 30, 2021
@Aylr Aylr deleted the clean-docs-tests-and-error-messages branch March 30, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants