Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] experimental column map expectation checking for vectors #3006

Conversation

manyshapes
Copy link
Contributor

Changes proposed in this pull request:
Adding an expectation that can check if column values are vectors: lists with more than two numbers and no strings.

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

  • none

Definition of Done

Please delete options that are not relevant.

  • [x ] My code follows the Great Expectations style guide
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation

@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ Deploy Preview for knoxpod ready!

🔨 Explore the source changes: e36ab2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/knoxpod/deploys/60e7bac476542300082d6841

😎 Browse the preview: https://deploy-preview-3006--knoxpod.netlify.app

@manyshapes
Copy link
Contributor Author

Resubmitting with different code

@manyshapes manyshapes closed this Jul 22, 2021
@manyshapes manyshapes deleted the feature/expect_column_values_to_be_vectors branch July 22, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant