Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Analysis of static typing / mypy coverage in GE #3122

Closed
wants to merge 8 commits into from
Closed

[WIP] Analysis of static typing / mypy coverage in GE #3122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f6ac11
feat: Pipe mypy output to file
cdkini Jul 27, 2021
16276a3
feat: Move to Pandas' mypy settings
cdkini Jul 27, 2021
7359806
feat: Add mypy JSON
cdkini Jul 27, 2021
297bf00
Merge branch 'develop' into MAINTENANCE/convert_great_expectations_co…
cdkini Jul 28, 2021
392ed0a
feat: Simplify mypy config
cdkini Jul 28, 2021
83784a9
Merge branch 'develop' of github.com:great-expectations/great_expecta…
cdkini Jul 28, 2021
4187129
Merge branch 'MAINTENANCE/convert_great_expectations_codebase_to_stat…
cdkini Jul 28, 2021
f42b6be
Merge branch 'develop' into MAINTENANCE/convert_great_expectations_co…
cdkini Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[mypy]
ignore_missing_imports = True
; check_untyped_defs = True
; no_implicit_optional = True
; disallow_untyped_defs = True
244 changes: 244 additions & 0 deletions mypy_output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,244 @@
{
"great_expectations": {
"_version.py": 1,
"datasource": {
"data_connector": {
"asset": {
"asset.py": 8
},
"data_connector.py": 10,
"util.py": 3,
"runtime_data_connector.py": 15,
"inferred_asset_sql_data_connector.py": 6,
"inferred_asset_s3_data_connector.py": 1,
"inferred_asset_filesystem_data_connector.py": 1,
"file_path_data_connector.py": 5,
"configured_asset_sql_data_connector.py": 1,
"configured_asset_s3_data_connector.py": 1,
"configured_asset_file_path_data_connector.py": 6,
"batch_filter.py": 10,
"sorter": {
"sorter.py": 1
}
},
"batch_kwargs_generator": {
"batch_kwargs_generator.py": 1,
"subdir_reader_batch_kwargs_generator.py": 1,
"s3_subdir_reader_batch_kwargs_generator.py": 1
},
"sqlalchemy_datasource.py": 1,
"simple_sqlalchemy_datasource.py": 2,
"new_datasource.py": 12
},
"core": {
"id_dict.py": 1,
"batch_spec.py": 2,
"util.py": 16,
"expectation_suite.py": 2,
"batch.py": 14,
"usage_statistics": {
"usage_statistics.py": 1
}
},
"types": {
"base.py": 3
},
"expectations": {
"metrics": {
"util.py": 4,
"metric_provider.py": 10,
"map_metric_provider.py": 31,
"column_aggregate_metric.py": 1,
"table_metrics": {
"table_columns.py": 3,
"table_column_count.py": 12
},
"column_map_metrics": {
"column_values_z_score.py": 1,
"column_values_increasing.py": 1,
"column_values_decreasing.py": 1
},
"column_aggregate_metrics": {
"column_quantile_values.py": 1,
"column_most_common_value.py": 8,
"column_median.py": 8,
"column_distinct_values.py": 4
}
},
"row_conditions.py": 4,
"registry.py": 18,
"expectation.py": 41,
"core": {
"expect_table_row_count_to_equal_other_table.py": 1,
"expect_table_row_count_to_equal.py": 1,
"expect_table_columns_to_match_set.py": 7,
"expect_table_columns_to_match_ordered_list.py": 10,
"expect_table_column_count_to_equal.py": 4,
"expect_select_column_values_to_be_unique_within_record.py": 2,
"expect_multicolumn_values_to_be_unique.py": 2,
"expect_multicolumn_sum_to_equal.py": 2,
"expect_compound_columns_to_be_unique.py": 2,
"expect_column_values_to_not_match_regex_list.py": 2,
"expect_column_values_to_not_match_regex.py": 2,
"expect_column_values_to_not_match_like_pattern_list.py": 8,
"expect_column_values_to_not_match_like_pattern.py": 6,
"expect_column_values_to_not_be_null.py": 1,
"expect_column_values_to_not_be_in_set.py": 3,
"expect_column_values_to_match_strftime_format.py": 2,
"expect_column_values_to_match_regex_list.py": 2,
"expect_column_values_to_match_regex.py": 2,
"expect_column_values_to_match_like_pattern_list.py": 8,
"expect_column_values_to_match_like_pattern.py": 6,
"expect_column_values_to_match_json_schema.py": 2,
"expect_column_values_to_be_unique.py": 4,
"expect_column_values_to_be_of_type.py": 9,
"expect_column_values_to_be_null.py": 1,
"expect_column_values_to_be_json_parseable.py": 1,
"expect_column_values_to_be_increasing.py": 2,
"expect_column_values_to_be_in_set.py": 7,
"expect_column_values_to_be_decreasing.py": 2,
"expect_column_values_to_be_dateutil_parseable.py": 1,
"expect_column_values_to_be_between.py": 6,
"expect_column_value_lengths_to_equal.py": 2,
"expect_column_value_lengths_to_be_between.py": 3,
"expect_column_to_exist.py": 9,
"expect_column_quantile_values_to_be_between.py": 7,
"expect_column_parameterized_distribution_ks_test_p_value_to_be_greater_than.py": 2,
"expect_column_pair_values_to_be_in_set.py": 3,
"expect_column_pair_cramers_phi_value_to_be_less_than.py": 1,
"expect_column_most_common_value_to_be_in_set.py": 2,
"expect_column_kl_divergence_to_be_less_than.py": 5,
"expect_column_distinct_values_to_equal_set.py": 1,
"expect_column_distinct_values_to_contain_set.py": 6,
"expect_column_distinct_values_to_be_in_set.py": 6,
"expect_column_chisquare_test_p_value_to_be_greater_than.py": 2,
"expect_column_bootstrapped_ks_test_p_value_to_be_greater_than.py": 2,
"expect_column_values_to_be_in_type_list.py": 11,
"expect_column_value_z_scores_to_be_less_than.py": 2
}
},
"exceptions": {
"exceptions.py": 1
},
"render": {
"util.py": 2,
"view": {
"view.py": 7
},
"renderer": {
"page_renderer.py": 4,
"notebook_renderer.py": 3,
"content_block": {
"content_block.py": 1,
"exception_list_content_block.py": 4,
"bullet_list_content_block.py": 1,
"validation_results_table_content_block.py": 2
},
"suite_edit_notebook_renderer.py": 5,
"datasource_new_notebook_renderer.py": 1,
"checkpoint_new_notebook_renderer.py": 4,
"suite_scaffold_notebook_renderer.py": 3,
"v3": {
"suite_profile_notebook_renderer.py": 4,
"suite_edit_notebook_renderer.py": 13
}
}
},
"data_context": {
"types": {
"base.py": 10
},
"util.py": 3,
"data_context.py": 50,
"store": {
"tuple_store_backend.py": 3,
"store_backend.py": 1,
"query_store.py": 1,
"metric_store.py": 1,
"ge_cloud_store_backend.py": 1,
"database_store_backend.py": 1,
"checkpoint_store.py": 5,
"util.py": 1
}
},
"validation_operators": {
"types": {
"validation_operator_result.py": 31
},
"validation_operators.py": 5
},
"checkpoint": {
"types": {
"checkpoint_result.py": 31
},
"util.py": 2,
"configurator.py": 6,
"checkpoint.py": 24
},
"util.py": 15,
"validator": {
"validator.py": 10
},
"profile": {
"basic_dataset_profiler.py": 5,
"user_configurable_profiler.py": 2,
"json_schema_profiler.py": 3
},
"execution_engine": {
"sqlalchemy_execution_engine.py": 10,
"sparkdf_execution_engine.py": 5,
"pandas_execution_engine.py": 3,
"execution_engine.py": 2
},
"dataset": {
"sqlalchemy_dataset.py": 16,
"sparkdf_dataset.py": 3
},
"rule_based_profiler": {
"domain_builder": {
"types": {
"domain.py": 2
},
"simple_semantic_type_domain_builder.py": 8,
"simple_column_suffix_domain_builder.py": 3,
"domain_builder.py": 2,
"column_domain_builder.py": 2
},
"util.py": 5,
"parameter_builder": {
"parameter_container.py": 7,
"parameter_builder.py": 6,
"numeric_metric_range_multi_batch_parameter_builder.py": 36,
"metric_parameter_builder.py": 2
},
"expectation_configuration_builder": {
"default_expectation_configuration_builder.py": 5
},
"rule": {
"rule.py": 5
},
"profiler.py": 6
},
"cli": {
"python_subprocess.py": 6,
"v012": {
"python_subprocess.py": 6,
"util.py": 2,
"toolkit.py": 11,
"checkpoint.py": 3
},
"batch_request.py": 11,
"toolkit.py": 31,
"util.py": 1,
"suite.py": 21,
"checkpoint.py": 3,
"datasource.py": 3
},
"self_check": {
"util.py": 7
},
"jupyter_ux": {
"__init__.py": 1
}
}
}