Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fixed typo and added CLA links #3347

Merged
merged 4 commits into from Sep 14, 2021

Conversation

kyleaton
Copy link
Member

@kyleaton kyleaton commented Sep 2, 2021

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • fixed typo and added CLA links in docs/contributing/contributing

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: b4140e3

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6141089d8d7e3000089fcb9c

😎 Browse the preview: https://deploy-preview-3347--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

Copy link
Contributor

@talagluck talagluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just made a suggestion to remove one broken link

docs/contributing/contributing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@talagluck talagluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@talagluck talagluck enabled auto-merge (squash) September 14, 2021 20:40
@talagluck
Copy link
Contributor

Closes #3344

@talagluck talagluck merged commit acc3a7e into develop Sep 14, 2021
@talagluck talagluck deleted the BUGFIX/issue_3344/contributing_doc_cla_link_broken branch September 14, 2021 20:40
Shinnnyshinshin pushed a commit that referenced this pull request Sep 17, 2021
* develop:
  Release Prep release-prep-2021-09-16 (#3402)
  [MAINTENANCE] Clean Up ValidationGraph API Usage, Improve Exception Handling for Metrics, Clean Up Type Hints (#3399)
  [FEATURE] Configurable multi-threaded checkpoint speedup (#3362)
  [BUGFIX] fix error getting validation result from DataContext (#3359)
  Fix incorrect ToC section name (#3395)
  Bugfix/skip substitute config variables in ge cloud mode (#3393)
  [BUGFIX] fixed typo and added CLA links (#3347)
  [MAINTENANCE] Clean up ValidationGraph API and add Type Hints (#3392)
  Enhancement/update  _set methods with kwargs (#3391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLA link is broken
3 participants