Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] update list_expectation_suite_names and ExpectationSuiteValidationResult payload #3419

Merged
merged 7 commits into from
Sep 20, 2021

Conversation

roblim
Copy link
Member

@roblim roblim commented Sep 20, 2021

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • update DataContext.list_expectation_suite_names to work with ge_cloud such that GE Cloud IDs are returned instead of Expectation Suite names
  • update ExpectationSuiteValidationResult POST payload to include expectation_suite_ge_cloud_id - this id is used in GE Cloud to fetch the corresponding suite to obtain the associated clause_id, which is then added to the result
  • add a new DataDocs view renderer that outputs a minimal page with no side or top nav

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: d45db73

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6148a3a824a2da0007bed5f7

😎 Browse the preview: https://deploy-preview-3419--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

@roblim roblim enabled auto-merge (squash) September 20, 2021 15:24
@rreinoldsc rreinoldsc self-requested a review September 20, 2021 15:28
@roblim roblim merged commit 0007ecc into develop Sep 20, 2021
@roblim roblim deleted the enhancement/update-list-expectation-suite-names branch September 20, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants