Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] recommending adding CLI link, Update contributing_test.md #3519

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

plain-jane-gray
Copy link
Contributor

Recommend adding link to "How to use the Great Expectations command line interface (CLI)"

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Adding link to "How to use the Great Expectations command line interface (CLI)" in documentations, as a recommendation

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • [x ] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

Recommend adding link to "How to use the Great Expectations command line interface (CLI)"
@netlify
Copy link

netlify bot commented Oct 9, 2021

👷 Deploy request for niobium-lead-7998 pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 1e4ae4a

Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @plain-jane-gray!

@austiezr
Copy link
Contributor

@cla-bot check

@austiezr austiezr merged commit 2df9ac0 into great-expectations:develop Oct 18, 2021
Shinnnyshinshin pushed a commit that referenced this pull request Oct 21, 2021
…reat-expectations/great_expectations into docs/GREAT-302/migration-guide

* 'docs/GREAT-302/migration-guide' of https://github.com/great-expectations/great_expectations: (27 commits)
  [FEATURE] Migration of Expectations to Atomic Prescriptive Renderers part 1 (#3530)
  [DOCS]Minor Friction (#3574)
  CLOUD-99: Editing Expectation Suites programmatically  (#3564)
  fix link to expectation glossary (#3558)
  [BUGFIX] SQLAlchemy version 1.3.24 compatibility in map metric provider (#3507)
  [DOCS] Removed duplicate prereq, how_to_instantiate_a_data_context_without_a_yml_file.md (#3481)
  better version control (#3565)
  [MAINTENANCE] Make CLI Check-Config and CLI More Robust (#3562)
  Update contributing_checklist.md (#3518)
  [DOCS] How to introspect and partition an SQL database (#3465)
  Docs/simplify getting started (#3555)
  Update contributing.md (#3524)
  Update contributing.md (#3523)
  Docs/revamp style guides (#3554)
  Update contributing_test.md (#3519)
  Update contributing_style.md (#3521)
  [DOCS] Improved installation instructions, included in-line installation instructions to getting started (#3509)
  Update how_to_configure_a_new_data_context_with_the_cli.md (#3556)
  typo in documentation (#3542)
  update expect_column_values_to_be_us_zipcode_within_radius_of_given_zipcode requirements
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants