Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update how to host and share data docs on GCS #3889

Merged

Conversation

NathanFarmer
Copy link
Contributor

Changes proposed in this pull request:

  • GREAT-404
  • Subtask: GREAT-410
  • Bring the code in "How to host and share data docs on GCS" under test
  • Extensive use of gsutil to test Google Cloud SDK

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: adb995f

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61c244707513a80008467ef7

😎 Browse the preview: https://deploy-preview-3889--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

Comment on lines +66 to +76
] = "how_to_configure_an_expectation_store_in_gcs/expectations"

try:
# remove this bucket if there was a failure in the script last time
result = subprocess.run(
"gsutil rm -r gs://superconductive-integration-tests/how_to_configure_an_expectation_store_in_gcs/expectations".split(),
check=True,
stderr=subprocess.PIPE,
)
except Exception as e:
pass
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this file following conversations on the validation store doc about bucket prefixes and cleaning up directories on each test run.

@NathanFarmer NathanFarmer marked this pull request as ready for review December 21, 2021 21:42
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NathanFarmer NathanFarmer merged commit f876b88 into develop Dec 22, 2021
@NathanFarmer NathanFarmer deleted the docs/GREAT-404/GREAT-410/clean-up-store-data-docs-gcs branch December 22, 2021 12:26
Shinnnyshinshin pushed a commit that referenced this pull request Dec 23, 2021
* develop:
  [BUGFIX] `PandasExecutionEngine` is able to instantiate Google Storage client in Google Cloud Composer, with some additional refactoring around Azure and S3 clients (#3896)
  release candidate for 0.13.48 (#3900)
  [DOCS ]Organize metadata store sidebar category by type of store (#3890)
  [DOCS] Update how to host and share data docs on GCS (#3889)
  [DOCS] Update how to configure a validation result store in GCS (#3887)
  [DOCS] Update how to configure an expectation store in GCS (#3874)
  [MAINTENANCE] Clean up Metrics type usage, SQLAlchemyExecutionEngine and SQLAlchemyBatchData implementation, and SQLAlchemy API usage (#3884)
  [MAINTENANCE] `add_expectation()` in `ExpectationSuite` supports usage statistics for GE.  (#3824)
  [DOCS] Add docs on creating suites with the UserConfigurableProfiler (#3877)
  [DOCS] Updates to configuring credentials (#3856)
  release candidate for 0.13.47 (#3880)
  raising exceptions in cloud mode (#3866)
  [MAINTENANCE] Test for errors / invalid messages in logs & fix various existing issues (#3875)
  [MAINTENANCE] Use f-string to prevent string concat issue in Evaluation Parameters (#3864)
  [MAINTENANCE] Add logging around DatasourceInitializationError in DataContext (#3846)
  fix: update convert_to_json_serializable (#3865)
  [FEATURE] Add support for named groups in data asset regex (#3855)
  Fix sqlalchemy expect_compound_columns_to_be_unique (#3827)
  [BUGFIX] Make ExpectationContext optional and remove when null to ensure backwards compatability (#3859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants