-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Marshmallow schema for Rule Based Profiler #3982
[FEATURE] Marshmallow schema for Rule Based Profiler #3982
Conversation
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: ebdd551 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61e0da1c940108000780c1d2 😎 Browse the preview: https://deploy-preview-3982--niobium-lead-7998.netlify.app |
HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖Please don't forget to add a clear and succinct description of your change under the Develop header in ✨ Thank you! ✨ |
…tions into feature/great-464/great-481/marshmallow-schema-for-rule-based-profiler
…tions into feature/great-464/great-481/marshmallow-schema-for-rule-based-profiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress! I only left a few questions/comments -- hopefully they are useful. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wonderful @cdkini and thank you @alexsherstinsky for the review as well.
The only question I have is regarding frozen=True
. Would love to hear from @donaldheppner, and similar to @cdkini I'd like lean towards keeping things immutable unless necessary (just my 2-cents for now).
…chema-for-rule-based-profiler
…chema-for-rule-based-profiler
…chema-for-rule-based-profiler
…tions into feature/great-464/great-481/marshmallow-schema-for-rule-based-profiler
…-based-profiler' of github.com:great-expectations/great_expectations into feature/great-464/great-481/marshmallow-schema-for-rule-based-profiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙇🏼
…chema-for-rule-based-profiler
…chema-for-rule-based-profiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- what a beautiful effort @cdkini !!!
… of https://github.com/great-expectations/great_expectations into MAINTENANCE/GREAT-504/postgres-example-migration-guide * 'MAINTENANCE/GREAT-504/postgres-example-migration-guide' of https://github.com/great-expectations/great_expectations: [FEATURE] Enable Rule-Based Profile Parameter Access To Collection Typed Values (#3998) [DOCS] Migration Guide now includes example for Spark data (#3996) update custom docs css to add a subtle border around tabbed content (#4001) Update how_to_configure_an_expectation_store_in_amazon_s3.md (#3971) [FEATURE] Marshmallow schema for Rule Based Profiler (#3982)
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!