[MAINTENANCE] Small refactor for tests that allows DB setup to be done from all tests #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: a53b495 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61e7148f8756d90007b61cee 😎 Browse the preview: https://deploy-preview-4012--niobium-lead-7998.netlify.app |
HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖Please don't forget to add a clear and succinct description of your change under the Develop header in ✨ Thank you! ✨ |
Shinnnyshinshin
changed the title
Shinnnyshinshin
commented
Jan 18, 2022
| @@ -104,25 +104,21 @@ class BackendDependencies(enum.Enum): | |||
| "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/how_to_choose_which_dataconnector_to_use.py", | |||
| "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | |||
| "data_dir": "tests/test_sets/dataconnector_docs", | |||
| "util_script": "tests/integration/docusaurus/connecting_to_your_data/database/util.py", | |||
There was a problem hiding this comment.
util_script is not needed for data_connector tests
Shinnnyshinshin
requested review from
NathanFarmer,
alexsherstinsky,
cdkini,
donaldheppner and
anthonyburdi
NathanFarmer
approved these changes
Jan 18, 2022
Shinnnyshinshin
deleted the
MAINTENANCE/GREAT-504/move-util-to-somewhere-better
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
[DOCS] Migration Guide now includes example for Databases #4005 requires a util function that was previously only used by tests in the folder
docusaurus/connecting_to_your_data/database, which loads data into a test DB. The "simplest" way to make sure the Migration Guide tests also had access to this function this involved making an additional copy of theutil.pyfile, which we wanted to avoid.This is made slightly more complicated by the fact that test directories for Docusaurus integration tests are generated fresh for each test, and we don't have access to
great_expectations/tests/directory within each test.This PR does two things.
load_data_into_test_database()into thetests/test_utils.pyfile where it can be accessed from all tests. In the process we also add a boolean flag that determines whether the full dataset or only the first 10 lines will be loaded into the test database (first 10 lines by default).test_script_runner.pyfile + associated tests to use this new function.Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!