New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] MapMetricColumnDomainBuilder for Rule-Based Profiler #4353
Conversation
…xsherstinsky/rule_based_profiler_implement_uniqueness_column_domain_builder-2022_03_07-41
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: e2e111d 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6227ed1ae56dfd000754cf8a 😎 Browse the preview: https://deploy-preview-4353--niobium-lead-7998.netlify.app |
…xsherstinsky/rule_based_profiler_implement_uniqueness_column_domain_builder-2022_03_07-41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending changes discussed (adding example in docstring for min_max parameter, splitting bobby test into 3 tests with descriptive names)
…xsherstinsky/rule_based_profiler_implement_uniqueness_column_domain_builder-2022_03_07-41
…xsherstinsky/rule_based_profiler_implement_uniqueness_column_domain_builder-2022_03_07-41
Scope
MapMetricColumnDomainBuilder
-- it accepts any column type map metric along with the intra-batch maximum for theunexpected_values
and inter-batch minimum ratio for not exceeding these maxima on average. It then outputs columnDomain
objects, satisfying these tolerance requirements.MapMetricColumnDomainBuilder
for the single-batch and multi-batch scenarios.Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123
).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!