Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file_size flexibility #440

Merged
merged 5 commits into from
Apr 23, 2019
Merged

Improve file_size flexibility #440

merged 5 commits into from
Apr 23, 2019

Conversation

jcampbell
Copy link
Member

No description provided.

@jcampbell jcampbell requested a review from abegong April 23, 2019 14:03
@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 93.842% when pulling d671ed3 on feature/enhanced_validation_support into 2e3b828 on develop.

@jcampbell
Use impossible-to-coerce examples in TypeError tests
92e6a01 
 - Also correct typo in error message
@jcampbell
Merge branch 'feature/enhanced_validation_support' of github.com:grea…
ee4d100 
…t-expectations/great_expectations into feature/enhanced_validation_support
@jcampbell
Use more pythonic exception types
d671ed3
abegong
abegong approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@abegong abegong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch

@jcampbell jcampbell merged commit 4531136 into develop Apr 23, 2019
@jcampbell jcampbell deleted the feature/enhanced_validation_support branch April 23, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abegong abegong abegong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcampbell @coveralls @abegong