New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HACKATHON] add expect_column_values_to_be_valid_us_state_abbrevation #4650
[HACKATHON] add expect_column_values_to_be_valid_us_state_abbrevation #4650
Conversation
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just needs a pass with isort
(it wants a linebreak after the us
import) and requirements
added to library_metadata
e3ae44e
to
d5fe337
Compare
…s://github.com/Derekma73/great_expectations into ExpectColumnValuesToBeValidUSStateAbbreviation
Something weird happened with this branch. @austiezr what changes need to be made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change; otherwise LGTM!
...ctations_experimental/expectations/expect_column_values_to_be_valid_us_state_abbreviation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Derekma73 thanks for your submission! Be sure to link this PR in your DevPost submission as well. 🚀
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open-source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in GitHub issues or slack, so please link to relevant conversations in the notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123
).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!