Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACKATHON] add expect_column_values_to_be_valid_ar_zip #4719

Conversation

Derekma73
Copy link
Contributor

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • added an expectation that all values in a column will be a valid Arkansas zipcode

After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Apr 6, 2022

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5e45d56

Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pulling zips for Arkansas (AR) but labeled throughout for Arizona, which has already been submitted.

@austiezr austiezr added community devrel This item is being addressed by the Developer Relations Team hackathon-2022 labels Apr 7, 2022
@austiezr
Copy link
Contributor

austiezr commented Apr 7, 2022

Hey @Derekma73 ! Sorry for the lack of clarity here; you've already submitted (now approved and merged) this expectation for Arizona. I think you may want to look at this submission & #4718 and resolve Alaska / Arkansas appropriately.

@Derekma73
Copy link
Contributor Author

whoops! should be all good now

@Derekma73 Derekma73 requested a review from austiezr April 7, 2022 21:47
Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Derekma73 !

@austiezr austiezr enabled auto-merge (squash) April 7, 2022 22:16
@austiezr austiezr merged commit 5b7a6a5 into great-expectations:develop Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community devrel This item is being addressed by the Developer Relations Team hackathon-2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants