[FEATURE] Add support for returning fully-qualified parameters names/values from RuleOutput object #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
April 5, 2022 13:36
…ky/rule_based_profiler/introduce_rule_state_class-2022_04_05-80
…ky/rule_based_profiler/introduce_rule_state_class-2022_04_05-80
…ler in support of richer use cases (such as DataAssistant).
…ky/rule_based_profiler/introduce_rule_state_class-2022_04_05-80
…ky/rule_based_profiler/introduce_rule_state_class-2022_04_05-80
…ky/rule_based_profiler/introduce_rule_state_class-2022_04_05-80
…5/GREAT-597/alexsherstinsky/rule_based_profiler/add_support_for_returning_parameters_and_metrics_as_rule_output-2022_04_06-83
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alexsherstinsky
requested review from
cdkini,
donaldheppner,
anthonyburdi,
NathanFarmer and
Shinnnyshinshin
and removed request for
cdkini and
donaldheppner
Shinnnyshinshin
approved these changes
Apr 6, 2022
| @@ -364,7 +349,7 @@ def expectation_suite( | |||
|
|
|||
| return expectation_suite | |||
|
|
|||
| def expectation_configurations(self) -> List[ExpectationConfiguration]: | |||
| def get_expectation_configurations(self) -> List[ExpectationConfiguration]: | |||
alexsherstinsky
deleted the
feature/GREAT-735/GREAT-791/alexsherstinsky/rule_based_profiler/add_support_for_returning_parameters_as_rule_output-2022_04_06-84
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Apr 7, 2022
…ckpoint' of https://github.com/great-expectations/great_expectations into feature/CLOUD-839/GREAT-767/runtime-data-connector-assets * 'DOCS/DOC-212/how_to_validate_data_with_an_in_memory_checkpoint' of https://github.com/great-expectations/great_expectations: (22 commits) -correction to line reference -corrections to python version of the config reference script - formatted sample scripts with black - updated line numbers in document -updated line numbers for script references - Added example scripts with asserts for testing for use as referenced files in documentation. - Added example scripts to test_script_runner.py Remove bootstrap tests that are no longer needed (#4818) - correct typo in URL in script docstring (#4817) - Update how-to guide content - Update old documentation to point to new how-to guide. Maintenance/check for mostly equals 1 in renderers (#4815) Update tutorial_review.md (#4611) Update README.md (#4595) fix IPython deprecation warning (#4301) [FEATURE] Add support for returning fully-qualified parameters names/values from RuleOutput object (#4773) [MAINTENANCE] Remove unused bootstrap methods that were migrated to ML Flow (#4742) fix: update module_name in NoteBookConfigSchema from v2 path to v3 (#4589) [HACKATHON] ExpectColumnValuesToBeValidTcpPort (#4634) [FEATURE] Introducing RuleState class and RuleOutput class for Rule-Based Profiler in support of richer use cases (such as DataAssistant). (#4704) revert to not raising datasource errors on data context init (#4732) Add checks for mostly=1.0 for all renderers (#4736) Maintenance/improve get validator functionality (#4661) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!