[MAINTENANCE] Refactor RuleBasedProfilerConfig
#4882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…_expectations into maintenance/great-464/great-610/refactor-rbp-config-types
…_expectations into maintenance/great-464/great-610/refactor-rbp-config-types
cdkini
commented
Apr 19, 2022
Comment on lines
100
to
102
| if config.get("class_name") == "RuleBasedProfiler": | ||
| config.pop("class_name", None) | ||
| config.pop("module_name", None) |
There was a problem hiding this comment.
Ugh this is ugly - how do I differentiate between subclasses that want these attrs and those that don't?
…_expectations into maintenance/great-464/great-610/refactor-rbp-config-types
…es' of https://github.com/great-expectations/great_expectations into maintenance/great-464/great-610/refactor-rbp-config-types
…_expectations into maintenance/great-464/great-610/refactor-rbp-config-types
cdkini
commented
Apr 19, 2022
Comment on lines
+419
to
+420
| config.pop("class_name", None) | ||
| config.pop("module_name", None) |
There was a problem hiding this comment.
Overrode the parent method because we need to pop these values. Could this be done in a cleaner fashion?
cdkini
requested review from
alexsherstinsky,
donaldheppner,
Shinnnyshinshin,
anthonyburdi and
NathanFarmer
Shinnnyshinshin
approved these changes
Apr 19, 2022
cdkini
deleted the
maintenance/great-464/great-610/refactor-rbp-config-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
class_nameandmodule_nameas arguments in the config constructor (as they as consistent between objects)Definition of Done
Please delete options that are not relevant.
Thank you for submitting!