Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Import GE after running ge init in packaging CI pipeline #4885

Conversation

anthonyburdi
Copy link
Member

@anthonyburdi anthonyburdi commented Apr 18, 2022

Changes proposed in this pull request:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@anthonyburdi anthonyburdi self-assigned this Apr 18, 2022
@netlify
Copy link

netlify bot commented Apr 18, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 28c1778
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/625da86948df4c00095a8909
😎 Deploy Preview https://deploy-preview-4885--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anthonyburdi anthonyburdi merged commit 19f1870 into develop Apr 18, 2022
@anthonyburdi anthonyburdi deleted the MAINTENANCE/none/none/add_ge_import_to_packaging_ci_pipeline branch April 18, 2022 18:30
Shinnnyshinshin pushed a commit that referenced this pull request Apr 18, 2022
…ts-part2-tests' of https://github.com/great-expectations/great_expectations into feature/CLOUD-839/GREAT-767/runtime-data-connector-assets-part2-tests

* 'feature/CLOUD-839/GREAT-767/runtime-data-connector-assets-part2-tests' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] Import GE after running `ge init` in packaging CI pipeline (#4885)
  [MAINTENANCE] Add CI stage importing GE with only required dependencies installed (#4884)
  [MAINTENANCE] `DataAssistantResult.plot()` conditional formatting and tooltips (#4881)
  [MAINTENANCE] split data context files (#4879)
  Add Tanner to CODEOWNERS for schemas.py (#4875)
  [BUGFIX] `great_expectations` import fails when SQL Alchemy is not installed (#4880)
  [FEATURE] Split data assets using sql datetime columns (#4871)
  [FEATURE] Plot metrics with `DataAssistantResult.plot()` (#4873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants