Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Improve error message outputted to user in DocstringChecker action #4895

Merged
merged 6 commits into from Apr 20, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Apr 19, 2022

Changes proposed in this pull request:

  • In order for devs to know the current count and see how it compares to the set threshold, showing the user information about failures (instead of successes) makes a lot of sense. As a dev, I don't need to manually calculate the number of failures (currently have to do total_funcs - total_passed).

Definition of Done

Please delete options that are not relevant.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 7c2bcf6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62604216cc250900087e55b6
😎 Deploy Preview https://deploy-preview-4895--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cdkini cdkini self-assigned this Apr 19, 2022
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdkini cdkini merged commit affb8af into develop Apr 20, 2022
@cdkini cdkini deleted the maintenance/update-docstring-coverage-checker branch April 20, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants