New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Add test to check for missing usage events #4933
Merged
anthonyburdi
merged 22 commits into
develop
from
MAINTENANCE/none/none/add_test_to_check_for_missing_usage_events
Apr 25, 2022
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
469f622
Add event to schema "data_context.run_profiler_with_dynamic_arguments"
anthonyburdi e0b8b33
Add new events to schemas.py
anthonyburdi b357d2c
Make sure all events from schemas.py have examples in valid_message_list
anthonyburdi 2b306dd
Make gather_source_files public for use elsewhere
anthonyburdi 254282a
First pass at test_all_events_are_in_schema()
anthonyburdi 663470b
Add new events
anthonyburdi 0829b82
Add new events to tests
anthonyburdi a6dd6e9
Merge branch 'develop' into BUGFIX/none/GREAT-815/add_missing_event_t…
anthonyburdi 74a3181
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi c96e418
Add new enum with all event names
anthonyburdi fa4eb05
Remove magic strings from calls to @usage_statistics_enabled_method
anthonyburdi 07cf891
Remove magic strings from calls to send_usage_message()
anthonyburdi feb3414
Cleanup
anthonyburdi efce827
Cleanup
anthonyburdi b21ec38
Docstrings
anthonyburdi a36708f
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi 3d12a18
Add test for "data_context.run_validation_operator", fix broken test
anthonyburdi 3a1792c
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi 7a3c3c9
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi 48c6c4c
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi 5f4c5d7
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi 39cf6e2
Merge branch 'develop' into MAINTENANCE/none/none/add_test_to_check_f…
anthonyburdi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these nouns or objects also become enums? I'm okay with how they're currently laid out just thinking out loud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, but we may also be able to get these from the click library as well. Let's plan for a future refactor with that in mind.