Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Cleanup variable naming for better readability #4949

Merged
merged 2 commits into from Apr 25, 2022
Merged

[MAINTENANCE] Cleanup variable naming for better readability #4949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a9cfdf
cleanup
Apr 25, 2022
9399108
Merge branch 'develop' into feature/GREAT-735/GREAT-746/alexsherstins…
alexsherstinsky Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 20 additions & 20 deletions tests/rule_based_profiler/data_assistant/test_volume_data_assistant.py
View file
Open in desktop
Expand Up @@ -73,7 +73,7 @@ def get_validator_with_expectation_suite(
expectation_suite_name: Optional[str] = None,
component_name: Optional[str] = None,
) -> Validator:
suite: ExpectationSuite
expectation_suite: ExpectationSuite

generate_temp_expectation_suite_name: bool
create_expectation_suite: bool
Expand Down Expand Up @@ -2715,13 +2715,13 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_n
):
context: DataContext = quentin_columnar_table_multi_batch_data_context

suite: ExpectationSuite = get_or_create_expectation_suite(
expectation_suite: ExpectationSuite = get_or_create_expectation_suite(
data_context=context,
expectation_suite=None,
expectation_suite_name="my_suite",
component_name=None,
)
assert len(suite.expectations) == 0
assert len(expectation_suite.expectations) == 0

batch_request: dict = {
"datasource_name": "taxi_pandas",
Expand All @@ -2733,7 +2733,7 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_n
batch_request=batch_request,
data_context=context,
expectation_suite_name=None,
expectation_suite=suite,
expectation_suite=expectation_suite,
component_name="volume_data_assistant",
)
assert len(validator.batches) == 36
Expand All @@ -2744,13 +2744,13 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_n
)
data_assistant_result: DataAssistantResult = data_assistant.run()

suite.add_expectation_configurations(
expectation_suite.add_expectation_configurations(
expectation_configurations=data_assistant_result.expectation_suite.expectations,
send_usage_event=False,
match_type="domain",
overwrite_existing=True,
)
assert len(suite.expectations) == 19
assert len(expectation_suite.expectations) == 19


def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_yes_use_suite_name(
Expand All @@ -2760,17 +2760,17 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_y

expectation_suite_name: str = "my_suite"

suite: ExpectationSuite
expectation_suite: ExpectationSuite

suite = get_or_create_expectation_suite(
expectation_suite = get_or_create_expectation_suite(
data_context=context,
expectation_suite=None,
expectation_suite_name=expectation_suite_name,
component_name=None,
)
assert len(suite.expectations) == 0
assert len(expectation_suite.expectations) == 0

context.save_expectation_suite(expectation_suite=suite)
context.save_expectation_suite(expectation_suite=expectation_suite)

batch_request: dict = {
"datasource_name": "taxi_pandas",
Expand All @@ -2782,7 +2782,7 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_y
batch_request=batch_request,
data_context=context,
expectation_suite_name=expectation_suite_name,
expectation_suite=suite,
expectation_suite=expectation_suite,
component_name="volume_data_assistant",
)
assert len(validator.batches) == 36
Expand All @@ -2798,41 +2798,41 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_y
expectation_suite_name=expectation_suite_name,
save_updated_expectation_suite=False,
)
suite: ExpectationSuite = get_or_create_expectation_suite(
expectation_suite = get_or_create_expectation_suite(
data_context=context,
expectation_suite=None,
expectation_suite_name=expectation_suite_name,
component_name=None,
)
assert len(data_assistant_result.expectation_suite.expectations) == 19
assert len(suite.expectations) == 0
assert len(expectation_suite.expectations) == 0

data_assistant_result = data_assistant.run(
expectation_suite_name=expectation_suite_name,
save_updated_expectation_suite=True,
)
suite: ExpectationSuite = get_or_create_expectation_suite(
expectation_suite = get_or_create_expectation_suite(
data_context=context,
expectation_suite=None,
expectation_suite_name=expectation_suite_name,
component_name=None,
)
assert len(data_assistant_result.expectation_suite.expectations) == 19
assert len(suite.expectations) == 19
assert len(expectation_suite.expectations) == 19


def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_yes_use_suite(
quentin_columnar_table_multi_batch_data_context,
):
context: DataContext = quentin_columnar_table_multi_batch_data_context

suite: ExpectationSuite = get_or_create_expectation_suite(
expectation_suite: ExpectationSuite = get_or_create_expectation_suite(
data_context=context,
expectation_suite=None,
expectation_suite_name="my_suite",
component_name=None,
)
assert len(suite.expectations) == 0
assert len(expectation_suite.expectations) == 0

batch_request: dict = {
"datasource_name": "taxi_pandas",
Expand All @@ -2844,7 +2844,7 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_y
batch_request=batch_request,
data_context=context,
expectation_suite_name=None,
expectation_suite=suite,
expectation_suite=expectation_suite,
component_name="volume_data_assistant",
)
assert len(validator.batches) == 36
Expand All @@ -2855,9 +2855,9 @@ def test_volume_data_assistant_add_expectation_configurations_to_suite_inplace_y
)
# noinspection PyUnusedLocal
data_assistant_result: DataAssistantResult = data_assistant.run(
expectation_suite=suite
expectation_suite=expectation_suite
)
assert len(suite.expectations) == 19
assert len(expectation_suite.expectations) == 19


def test_volume_data_assistant_plot_descriptive_notebook_execution_fails(
Expand Down