Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.15.4 #5035

Closed
wants to merge 38 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f61df26
[FEATURE] Introduce ParameterBuilder Evaluation Dependencies and Vali…
alexsherstinsky Mar 24, 2022
61ad9d8
[BUGFIX] Moves testing dependencies out of core reqs (#4522)
austiezr Mar 24, 2022
e80534a
[FEATURE] Convert Existing Self-Initializing Expectations to Make Exp…
alexsherstinsky Mar 25, 2022
dd1d564
[MAINTENANCE] Don't return from validate configuration methods (#4545)
kenwade4 Mar 25, 2022
c7895ee
[DOCS] technical term tags connect to data cloud docs (#4414)
Rachel-Reverie Mar 25, 2022
1d01a6d
- Update to include technical term tags. (#4462)
Rachel-Reverie Mar 25, 2022
99c131f
- Moved docs related to contributing integrations under contributing …
Rachel-Reverie Mar 25, 2022
5221749
- Adds new image files for the intro page (#4540)
Rachel-Reverie Mar 25, 2022
7aa6284
[DOCS] clarifications on execution engines and scalability (#4539)
Rachel-Reverie Mar 25, 2022
eaeae9e
[DOCS] technical terms for validate data advanced (#4535)
Rachel-Reverie Mar 25, 2022
61e88d1
[DOCS] technical terms for validate data actions docs (#4518)
Rachel-Reverie Mar 25, 2022
488434e
[MAINTENANCE] Rule-Based Profiler: Refactor utilities into appropriat…
alexsherstinsky Mar 25, 2022
4bb4752
[MAINTENANCE] Refactor global `conftest` (#4534)
cdkini Mar 25, 2022
af30eb0
[FEATURE] Improve diagnostic checklist details (#4548)
kenwade4 Mar 25, 2022
c9d0c58
clean up (#4554)
alexsherstinsky Mar 25, 2022
cfcafa1
minor touch up (#4558)
alexsherstinsky Mar 26, 2022
1e20c90
[MAINTENANCE] Refactor Anonymizer utilizing the Strategy design patte…
cdkini Mar 28, 2022
ef40e46
[MAINTENANCE] Remove duplicate mistune dependency
cdkini Mar 28, 2022
896145c
[MAINTENANCE] Run PEP-273 checks on a schedule or release cut
cdkini Mar 28, 2022
9b02d47
[DOCS] correct code reference line numbers and snippet tags for how t…
Rachel-Reverie Mar 28, 2022
ae825a3
[MAINTENANCE] Package dependencies usage stats instrumentation - part…
anthonyburdi Mar 28, 2022
f5da24e
[MAINTENANCE] Add DevRel team to GitHub auto-label action
cdkini Mar 28, 2022
d452d80
[MAINTENANCE] Add GitHub action to conditionally auto-update PR's (#…
cdkini Mar 28, 2022
a2738e0
[MAINTENANCE] Bump version of `black` in response to hotfix for Click…
cdkini Mar 28, 2022
ff4c67b
Update overview.md (#4556)
abegong Mar 29, 2022
156dcd1
- corrected broken link in admonition box. (#4585)
Rachel-Reverie Mar 29, 2022
fc83d52
[MAINTENANCE] Minor clean-up (#4571)
donaldheppner Mar 29, 2022
5ba269c
[BUGFIX] Adjust output of datetime `ParameterBuilder` to match Expect…
Mar 30, 2022
bfdfd2b
[MAINTENANCE] Instrument package dependencies (#4583)
anthonyburdi Mar 30, 2022
d7a5da0
[MAINTENANCE] Standardize DomainBuilder Constructor Arguments Orderin…
alexsherstinsky Mar 31, 2022
977033c
release candidate for 0.14.13
Mar 31, 2022
ff84860
revert to 0.14.12 state
Apr 8, 2022
3dafaad
Merge branch 'release-prep-2022-04-07'
Apr 8, 2022
c24784e
merge for 0.15.1 release
Apr 14, 2022
24179d9
0.15.1 release candidate v2
Apr 14, 2022
c639afe
Merge remote-tracking branch 'origin/develop'
allensallinger Apr 21, 2022
db29417
[RELEASE] 0.15.3 (#4981)
cdkini Apr 28, 2022
7b71b74
Merge remote-tracking branch 'origin/develop'
cdkini May 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 43 additions & 0 deletions great_expectations/expectations/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
logger = logging.getLogger(__name__)

_registered_expectations = {}
_registered_data_assistants = {}
_registered_metrics = {}
_registered_renderers = {}

Expand Down Expand Up @@ -94,6 +95,48 @@ def register_expectation(expectation: Type["Expectation"]) -> None: # noqa: F82
_registered_expectations[expectation_type] = expectation


def register_data_assistant(
data_assistant: Type["DataAssistant"], # noqa: F821
) -> None:
"""
This method executes "run()" of effective "RuleBasedProfiler" and fills "DataAssistantResult" object with outputs.

Args:
data_assistant: "DataAssistant" class to be registered
"""
data_assistant_type = data_assistant.data_assistant_type
if data_assistant_type in _registered_data_assistants:
if _registered_data_assistants[data_assistant_type] == data_assistant:
logger.info(
f'Multiple declarations of DataAssistant "{data_assistant_type}" found.'
)
return
else:
logger.warning(
f'Overwriting the declaration of DataAssistant "{data_assistant_type}" took place.'
)

logger.debug(
f'Registering the declaration of DataAssistant "{data_assistant_type}" took place.'
)
_registered_data_assistants[data_assistant_type] = data_assistant


def get_data_assistant_impl(
data_assistant_type: str,
) -> Optional[Type["DataAssistant"]]: # noqa: F821
"""
This method obtains (previously registered) "DataAssistant" class from DataAssistant Registry

Args:
data_assistant_type: String representing "snake case" version of "DataAssistant" class type

Returns:
Class inheriting "DataAssistant" if found; otherwise, None
"""
return _registered_data_assistants.get(data_assistant_type)


def _add_response_key(res, key, value):
if key in res:
res[key].append(value)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from great_expectations.core import ExpectationSuite
from great_expectations.core.batch import Batch, BatchRequestBase
from great_expectations.execution_engine.execution_engine import MetricDomainTypes
from great_expectations.expectations.registry import register_data_assistant
from great_expectations.rule_based_profiler.domain_builder import DomainBuilder
from great_expectations.rule_based_profiler.expectation_configuration_builder import (
ExpectationConfigurationBuilder,
Expand Down
7 changes: 7 additions & 0 deletions great_expectations/rule_based_profiler/rule_based_profiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ def run(

rule_state: RuleState
rule: Rule
domains_count: int = 0
for rule in effective_rules:
rule_state = rule.run(
variables=effective_variables,
Expand All @@ -295,6 +296,12 @@ def run(

progress_bar.close()

domains_count += len(rule_state.domains)
progress_bar.update(domains_count)
progress_bar.refresh()

progress_bar.close()

def get_expectation_suite(
self,
expectation_suite: Optional[ExpectationSuite] = None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,11 @@ def get_expect_values_to_be_between_chart(
)
anomaly_coded_line = alt.layer(line.layer[0], anomaly_coded_points)

return band + lower_limit + upper_limit + anomaly_coded_line
anomaly_coded_points = line.layer[1].encode(
color=point_color_condition, tooltip=tooltip
)
anomaly_coded_line = alt.layer(line.layer[0], anomaly_coded_points)
return anomaly_coded_line

@staticmethod
def get_interactive_detail_multi_line_chart(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1752,7 +1752,7 @@ def test_quentin_profiler_user_workflow_multi_batch_quantiles_value_ranges_rule(
}
],
"rule_count": 1,
"variable_count": 6,
"variable_count": 5,
},
"event": "profiler.run",
"success": True,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
Domain,
SemanticDomainTypes,
)
from great_expectations.rule_based_profiler.types import Domain
from great_expectations.rule_based_profiler.types.data_assistant_result import (
DataAssistantResult,
)
Expand Down