Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Remove condition from autoupdate GitHub action #5270

Merged
merged 2 commits into from Jun 8, 2022
Merged

[MAINTENANCE] Remove condition from autoupdate GitHub action #5270

merged 2 commits into from Jun 8, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Jun 8, 2022 •
edited

Changes proposed in this pull request:

  • This action never actually runs because the condition is never true - since it should only run once auto-merge is enabled, I've just deleted the condition and am hoping it now works 😄

Definition of Done

Please delete options that are not relevant.

@netlify
Copy link

netlify bot commented Jun 8, 2022 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 3464532
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62a1231c1d626400099b7b89
😎 Deploy Preview https://deploy-preview-5270--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jun 8, 2022 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@cdkini cdkini enabled auto-merge (squash) June 8, 2022 21:27
@cdkini cdkini self-assigned this Jun 8, 2022
Shinnnyshinshin
Shinnnyshinshin approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@cdkini cdkini merged commit 8f96efc into develop Jun 8, 2022
@cdkini cdkini deleted the maintenance/remove-condition-from-autoupdate-gh-action branch June 8, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees

@cdkini cdkini

Labels
core-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdkini @Shinnnyshinshin