Adds column scientific notation string validation #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devrel
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
No idea why lint is failing. Neither |
|
Weird! The checklist is throwing for |
austiezr
approved these changes
Jun 14, 2022
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jun 15, 2022
…ure/GREAT-953/migration-part1-move-to-abc * bugfix/GREAT-953/tests-deleting-env-variable: (21 commits) Update migration_guide_postgresql_v3_api.py [RELEASE] 0.15.10 (#5316) Fix links to example files (#5275) Expect column values to be valid scientific notation (#5311) removing module name Adds column value JSON validation (#5313) fixed test remove redundant fixture final clean up. remove redundant test added fixture again Update test_project.py [BUGFIX] Warning in Getting Started Guide notebook. (#5297) upgrading test lint fixes (#5312) Adds column scientific notation string validation (#5309) [MAINTENANCE] Fixing a typo in a comment (in several files) (#5310) [FEATURE] Support both UserConfigurableProfiler and OnboardingDataAssistant in "CLI SUITE NEW --PROFILE <name>" command (#5306) Adds column values ARN validation (#5304) Adds column values IATA code validation (#5303) Adds column values github user validation (#5302) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Definition of Done
Please delete options that are not relevant.
Thank you for submitting!