[MAINTENANCE] Ensure that changes made to env vars / config vars are recognized within subsequent calls of the same process #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
Shinnnyshinshin
approved these changes
Jun 29, 2022
Comment on lines
+2887
to
+2894
| """ | ||
| What does this test do and why? | ||
|
|
||
| Great Expectations recognizes changes made to environment variables within a program execution | ||
| and ensures that these changes are recognized in subsequent calls within the same process. | ||
|
|
||
| This is particularly relevant when performing substitutions within a user's project config. | ||
| """ |
There was a problem hiding this comment.
love the note. Thank you
cdkini
deleted the
maintenance/great-889/ensure-that-changes-to-env-vars-and-config-vars-are-recognized-in-the-same-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
Definition of Done
Please delete options that are not relevant.