[MAINTENANCE] Provide better error messaging if batch_request is not supplied to DataAssistant.run() #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsherstinsky
requested review from
NathanFarmer,
Shinnnyshinshin,
cdkini,
anthonyburdi,
billdirks and
donaldheppner
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
||
| pass | ||
|
|
||
|
|
||
| class ProfilerExecutionError(ProfilerError): | ||
| """A runtime error for a profiler.""" | ||
| """A runtime error for a "RuleBasedProfiler" class.""" |
Comment on lines
+454
to
+457
| if self._data_context is None: | ||
| usage_statistics_handler = None | ||
| else: | ||
| usage_statistics_handler = self._data_context._usage_statistics_handler |
There was a problem hiding this comment.
Making sure this variable always exists
Comment on lines
+197
to
+200
| raise ge_exceptions.DataAssistantExecutionError( | ||
| message=f"""Utilizing "{data_assistant_name}.run()" requires valid "batch_request" to be \ | ||
| specified (empty or missing "batch_request" detected).""" | ||
| ) |
alexsherstinsky
deleted the
feature/GREAT-761/GREAT-1038/alexsherstinsky/rule_based_profiler/data_assistant/improve_error_message_when_batch_request_not_specified_for_run_method-2022_07_08-183
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Previously, missing
batch_requestwould causeDataAssistant.run()to simply fail with anAttributeError. Now, a formal error message is provided.Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!